Repository navigation
Conversation
workflows' CommonService.subscribe defaults to acknowledging messages and extending log records with the recipe ID, which every service passed explicitly, and applies queue overrides given when the service is started. This replaces the hand-written overrides in the filewatcher, per-image analysis and X-ray centering services, and makes the queue overridable for every other recipe service. Services consuming several queues (archiver, s3echo collector and uploader) now refuse to start with an unnamed queue override, which they previously ignored. Use --queue NAME=QUEUE for these. Requires workflows with CommonService.subscribe.
workflows' service starter provides -q/--queue [NAME=]QUEUE, but only when the starter subclass hasn't defined its own. Removing the dlstbx option, which only accepted a single queue, enables it. A single queue is still passed to services the same way, and services consuming several queues can now have each one overridden by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires DiamondLightSource/python-workflows#212 to be merged and released