Repository navigation
Return failure when any imported package installation fails - #55
Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit intoOct 19, 2026
Conversation
Marc-André Moreau (mamoreau-devolutions)
force-pushed
the
fix/import-failure-exit-code
branch
from
October 19, 2026 14:32
e5f04ee to
dd202fd
Compare
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Oct 19, 2026
Marc-André Moreau (mamoreau-devolutions)
merged commit Oct 19, 2026
cd71a3e
into
Devolutions:master
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes import processing in Rust and .NET to retain package failures through the complete import run, continue attempting later packages, and return exit code
1if any non-ignored package fails. A later success, ignored unavailable package, or no-op cannot clear an earlier failure.Fixes .NET's unavailable-package classification to recognize the core repository's actual
no package matched the supplied querymessage as well as the existing spelling. Recognized package-not-found and no-applicable-installer errors remain ignorable with--ignore-unavailable; installer exit failures, hash verification errors, and arbitrary exceptions are not ignored.Preserves successful package-level dry-run behavior, including Rust search errors and missing packages, without invoking installers. Dry-run does not mask file parsing or repository initialization errors. No-op results and
--no-upgradeskips remain successful. .NET installed-state lookup errors are now handled per package, so they cannot stop later packages from being processed.Adds handler-level regression coverage in both implementations for mixed failure/success imports, thrown installer errors,
--ignore-unavailable, dry-run, and no-op behavior. Additional cases cover .NET installed-state lookup failures and Rust discovery errors. Updates the README's import behavior and compatibility limits.