Repository navigation
chore(openapi): add the recording search endpoint to the clients - #2114
Open
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 3 commits into
Open
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 3 commits into
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 3 commits into
Conversation
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
2 times, most recently
from
October 21, 2026 01:40
f0dd53b to
6b471bd
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
changed the base branch from
feat/recording-search
to
feat/recording-search-pagination
October 21, 2026 01:40
Contributor
Author
|
Lines changed, against #2137. All of it is generated, no hand-written code or tests:
The .NET client builds with 0 errors. |
irvingouj@Devolutions (irvingoujAtDevolution)
requested a review
from Benoît Cortier (CBenoit)
October 21, 2026 01:41
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 03:18
6b471bd to
c17efe1
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 03:39
c17efe1 to
2301b45
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 04:00
2301b45 to
8324e5e
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 04:13
8324e5e to
fac5fb1
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 13:22
fac5fb1 to
f81c67e
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
added this pull request to stack #2143
October 21, 2026 15:02
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 17:00
f81c67e to
a3c76e3
Compare
Copilot started reviewing on behalf of
irvingouj@Devolutions (irvingoujAtDevolution)
October 21, 2026 17:01
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The generated additions match the supplied search contract, with only a non-blocking documentation example correction remaining.
1 open issue
What changed in this PR
Exposes the recording search and pagination features from #2112 and #2137 through the OpenAPI specification and generated clients.
Changes:
- Adds search methods and request, response, selection, and time-range models.
- Adds the
gateway.recordings.searchaccess scope. - Updates generated documentation and file inventories.
| File | Description |
|---|---|
| devolutions-gateway/openapi/ts-angular-client/model/startTimeRange.ts | Adds time-range filters. |
| devolutions-gateway/openapi/ts-angular-client/model/recordingSelection.ts | Adds recording selection. |
| devolutions-gateway/openapi/ts-angular-client/model/recordingSearchResponse.ts | Adds paginated results. |
| devolutions-gateway/openapi/ts-angular-client/model/recordingSearchRequest.ts | Adds search parameters. |
| devolutions-gateway/openapi/ts-angular-client/model/recordingSearchHit.ts | Adds hit details. |
| devolutions-gateway/openapi/ts-angular-client/model/models.ts | Exports new models. |
| devolutions-gateway/openapi/ts-angular-client/model/accessScope.ts | Adds search scope. |
| devolutions-gateway/openapi/ts-angular-client/api/jrec.service.ts | Adds search operation. |
| devolutions-gateway/openapi/ts-angular-client/.openapi-generator/FILES | Registers generated models. |
| devolutions-gateway/openapi/gateway-api.yaml | Defines search endpoint and schemas. |
| devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/StartTimeRange.cs | Adds time-range filters. |
| devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/RecordingSelection.cs | Supports all recordings or ID lists. |
| devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/RecordingSearchResponse.cs | Adds paginated results. |
| devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/RecordingSearchRequest.cs | Adds search parameters. |
| devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/RecordingSearchHit.cs | Adds hit details. |
| devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/AccessScope.cs | Adds search scope. |
| devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Api/JrecApi.cs | Adds synchronous and asynchronous search. |
| devolutions-gateway/openapi/dotnet-client/README.md | Links search API and models. |
| devolutions-gateway/openapi/dotnet-client/docs/StartTimeRange.md | Documents time filters. |
| devolutions-gateway/openapi/dotnet-client/docs/RecordingSelection.md | Documents recording selection. |
| devolutions-gateway/openapi/dotnet-client/docs/RecordingSearchResponse.md | Documents paginated results. |
| devolutions-gateway/openapi/dotnet-client/docs/RecordingSearchRequest.md | Documents search parameters. |
| devolutions-gateway/openapi/dotnet-client/docs/RecordingSearchHit.md | Documents hit details. |
| devolutions-gateway/openapi/dotnet-client/docs/JrecApi.md | Documents search usage. |
| devolutions-gateway/openapi/dotnet-client/.openapi-generator/FILES | Registers generated files. |
| devolutions-gateway/openapi/doc/index.adoc | Adds search API reference. |
Review effort: Balanced
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 17:53
a3c76e3 to
e21d77d
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 17:58
e21d77d to
b1a7461
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 18:16
b1a7461 to
90161dc
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 18:24
90161dc to
c7e41d3
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 18:29
c7e41d3 to
5738d31
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 18:33
5738d31 to
319e28f
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 21, 2026 18:36
319e28f to
bf3cfd4
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 22, 2026 14:32
bf3cfd4 to
fc23dd0
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 22, 2026 16:19
fc23dd0 to
6639082
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 22, 2026 17:26
6639082 to
4a31163
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 22, 2026 17:58
4a31163 to
1caf91b
Compare
Regenerate `gateway-api.yaml`, the docs, the .NET client and the TS Angular client for `POST /jet/jrec/search`, its paging, and the `gateway.recordings.search` scope. Only the search parts are kept, because the generator also rewrites the `pullRecordingFile` content types, which belong to their own change. Issue: DGW-463 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regenerated with openapi-generator 7.9.0 after the search endpoint started matching the string values of JSON log lines. Only descriptions change: the endpoint, the hit and the response. Issue: DGW-463 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An empty query now matches every line, as in rg and grep, so the spec drops minLength on query and the .NET client drops its length check. The rest is the updated descriptions. Issue: DGW-463 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-search-openapi
branch
from
October 23, 2026 19:02
1caf91b to
85eb7e3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAPI side of the recording search endpoint (#2112) and its paging (#2137): the regenerated
gateway-api.yaml, docs, .NET client and TS Angular client.JrecApi/JrecServicegainSearchRecordings(POST /jet/jrec/search), with theRecordingSearchRequest,RecordingSelection,StartTimeRange,RecordingSearchResponseandRecordingSearchHitmodels.AccessScopegainsgateway.recordings.search.Only the search parts are kept, because the generator also rewrites the
pullRecordingFilecontent types.Where to look:
RecordingSelectioningateway-api.yaml, which is"all"or a list of IDs. In C# that'snew RecordingSelection("all")ornew RecordingSelection(List<Guid>).🤖 Generated with Claude Code
Issue: DGW-463