Skip to content

Auto connect locations on app start - #1307

Merged
filipslezaklab merged 5 commits into
devfrom
auto-start-locations
Nov 6, 2026
Merged

filipslezaklab merged 5 commits into
devfrom
auto-start-locations

Conversation

@filipslezaklab

@filipslezaklab filipslezaklab commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Related: #1113

auto start backend

autostart ui

revision one

update taskfile
@filipslezaklab filipslezaklab self-assigned this Oct 29, 2026
@filipslezaklab
filipslezaklab marked this pull request as draft October 29, 2026 12:56
@filipslezaklab filipslezaklab changed the title auto start backend Auto connect locations on app start Oct 29, 2026
@filipslezaklab
filipslezaklab marked this pull request as ready for review October 30, 2026 10:04
Comment thread src-tauri/src/auto_connect.rs Outdated
use super::*;

#[test]
fn test_is_retryable() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this test is useless

Comment thread src-tauri/Cargo.toml Outdated
regex = "1.13"
reqwest = { version = "0.13", features = ["cookies", "json"] }
rust-ini = "0.21"
same-file = "1.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crate is outdated. Use std API, for example:

/// Check if both paths lead to the same file, also through links.
#[cfg(unix)]
fn is_same_file(a: &Path, b: &Path) -> io::Result<bool> {
    use std::os::unix::fs::MetadataExt;
    let (a, b) = (fs::metadata(a)?, fs::metadata(b)?);
    Ok(a.dev() == b.dev() && a.ino() == b.ino())
}

/// Check if both paths lead to the same file, also through symbolic links.
#[cfg(not(unix))]
fn is_same_file(a: &Path, b: &Path) -> io::Result<bool> {
    Ok(fs::canonicalize(a)? == fs::canonicalize(b)?)
}

@filipslezaklab
filipslezaklab merged commit d6824e5 into dev Nov 6, 2026
9 checks passed
@filipslezaklab
filipslezaklab deleted the auto-start-locations branch November 6, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants