Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbc6c148cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "RUSTSEC-2026-0346", | ||
| "RUSTSEC-2026-0382", | ||
| "RUSTSEC-2026-0381", | ||
| ] |
There was a problem hiding this comment.
Remove the obsolete explanation for the deleted advisory ignore
Important: The commit description explicitly says the explanatory comments are removed together with this ignore, but the two-line RUSTSEC-2026-0381 explanation above [advisories] remains. It now documents an exception that is no longer configured and still claims that webpki-roots 0.26.11 is flagged, contrary to the stated reason for this cleanup. Remove that obsolete explanation so the configuration documentation and description agree, as required by AGENTS.md.
AGENTS.md reference: AGENTS.md:L64-L65
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the removal of the obsolete cargo-audit advisory suppression.
No open issues 🎉
What changed in this PR
Removes the obsolete RUSTSEC-2026-0381 suppression from cargo-audit configuration, addressing #205 and allowing future affected dependency versions to be reported.
Changes:
- Removes the advisory ignore entry and its two explanatory comment lines.
- Leaves all other audit settings unchanged; no Rust source, test, or lockfile changes.
Scope: 1 configuration line and 2 comment lines removed; 0 core-code or test lines changed.
| File | Description |
|---|---|
.cargo/audit.toml |
Removes the obsolete advisory suppression and its explanatory comments. |
Review effort: Balanced
Closes #205
What does this PR do?
.cargo/audit.tomlstill ignores the advisory below, butCargo.lockonmainno longer holds a version of the affected crate inside the affected range, so the entry no longer suppresses anything. This pull request removes it, together with the comments that explained it.Cargo.locknowwebpki-roots0.26.11, 1.0.10RustSec marked
webpki-roots0.26.11 as unaffected on 2026-10-21, the day after the advisory was published: that release only re-exports the 1.x root list. Since then the advisory no longer matches the 0.26.11 entry in a lock file.Why remove it. An ignore entry keeps muting the advisory id for as long as it stays in the file. If the crate were later pinned back to an affected version, cargo-audit would stay silent about it.
What was checked, and what was not.
mainat commit807d12a89423on 2026-11-21: the id is on an active line of the config, and no version of the affected crate inCargo.lockis inside the affected range of its advisory (RustSec records)..cargo/audit.toml. No Rust source and no lock file is changed. The edited file parses as TOML, and every other ignore entry and setting is unchanged.cargo auditlocally, because we do not build or execute anything from this repository. CI is the first run of the tool on this change.Disclosure: the check, the edit and this text were produced with automated tooling, including an LLM.
Feel free to close this if it is not useful.
Motivation
An ignore entry that no longer matches anything keeps muting the advisory id for as long as it stays in the file. See the description.
Additional Notes
Not applicable: this only concerns entries of the advisory ignore list.
Describe how to test/QA your changes
Not run locally. See the description for what was checked and what was not.