Skip to content

chore(deps): remove stale cargo-deny ignore for RUSTSEC-2026-0410 - #1538

Open
lym953 wants to merge 1 commit into
mainfrom
yiming.luo/remove-zstd-sys-advisory-ignore
Open

lym953 wants to merge 1 commit into
mainfrom
yiming.luo/remove-zstd-sys-advisory-ignore

Conversation

@lym953

@lym953 lym953 commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

This PR

Removes the cargo-deny ignore entry for RUSTSEC-2026-0410, a zstd-sys advisory. The entry matches no crate, so it hides nothing. If it stays and a later change pins zstd-sys back to an affected version, cargo-deny does not report the advisory.

The advisory is patched in zstd-sys 2.1.2. #1469 added the entry on 2026-10-29. One day later, #1467 bumped zstd-sys from 2.0.16 to 2.1.2 and kept the entry. Issue #1535 reported it.

Closes #1535

Testing

Steps

  1. Install the cargo-deny version that CI uses: cargo install --locked cargo-deny@0.20.2.
  2. In bottlecap, run the CI command, cargo deny --locked check, with and without the change.

Result

Check Before After
Warning for RUSTSEC-2026-0410 advisory-not-detected: "no crate matched advisory criteria" None
Result of cargo deny --locked check advisories ok, bans ok, licenses ok, sources ok advisories ok, bans ok, licenses ok, sources ok

🤖 Generated with Claude Code

zstd-sys is at 2.1.2, the patched version, so the entry matches no crate
and cargo-deny warns advisory-not-detected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lym953
lym953 marked this pull request as ready for review November 21, 2026 02:22
@lym953
lym953 requested a review from a team as a code owner November 21, 2026 02:22
@lym953
lym953 requested review from shreyamalpani and a balanced review from Copilot November 21, 2026 02:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T02:23:35.520244Z b889fc4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues blocking the removal of the obsolete zstd-sys advisory suppression.

No open issues 🎉

What changed in this PR

Removes a stale cargo-deny suppression now that zstd-sys is patched, addressing #1535 and restoring advisory detection if an affected version is reintroduced.

Changes:

  • Removes the RUSTSEC-2026-0410 ignore entry; all other advisory exceptions remain unchanged.
File Description
bottlecap/​deny.toml Removes the obsolete zstd-sys advisory suppression.

Review effort: Balanced

@datadog-official

datadog-official Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b889fc4 | Docs | View more details | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore entry for RUSTSEC-2026-0410 no longer matches anything (zstd-sys is already at 2.1.2+zstd.1.5.7)

3 participants