Repository navigation
Conversation
zstd-sys is at 2.1.2, the patched version, so the entry matches no crate and cargo-deny warns advisory-not-detected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lym953
marked this pull request as ready for review
November 21, 2026 02:22
lym953
requested review from
shreyamalpani
and
a balanced review from Copilot
November 21, 2026 02:22
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking the removal of the obsolete zstd-sys advisory suppression.
No open issues 🎉
What changed in this PR
Removes a stale cargo-deny suppression now that zstd-sys is patched, addressing #1535 and restoring advisory detection if an affected version is reintroduced.
Changes:
- Removes the
RUSTSEC-2026-0410ignore entry; all other advisory exceptions remain unchanged.
| File | Description |
|---|---|
bottlecap/deny.toml |
Removes the obsolete zstd-sys advisory suppression. |
Review effort: Balanced
Contributor
|
This comment will be updated automatically if new data arrives. 🔗 Commit SHA: b889fc4 | Docs | View more details | Give us feedback! |
shreyamalpani
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Removes the cargo-deny ignore entry for RUSTSEC-2026-0410, a
zstd-sysadvisory. The entry matches no crate, so it hides nothing. If it stays and a later change pinszstd-sysback to an affected version, cargo-deny does not report the advisory.The advisory is patched in
zstd-sys2.1.2. #1469 added the entry on 2026-10-29. One day later, #1467 bumpedzstd-sysfrom 2.0.16 to 2.1.2 and kept the entry. Issue #1535 reported it.Closes #1535
Testing
Steps
cargo install --locked cargo-deny@0.20.2.bottlecap, run the CI command,cargo deny --locked check, with and without the change.Result
advisory-not-detected: "no crate matched advisory criteria"cargo deny --locked checkadvisories ok, bans ok, licenses ok, sources okadvisories ok, bans ok, licenses ok, sources ok🤖 Generated with Claude Code