Repository navigation
♻️ Simplify profiler cleanup and stop transitions - #5298
Draft
amortemousque wants to merge 1 commit into
Draft
amortemousque wants to merge 1 commit into
amortemousque wants to merge 1 commit into
Conversation
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: f428c41 | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Profiler shutdown duplicates timer cleanup, listener removal, and trace disposal. The nested stop-state checks also make it harder to follow which stop reasons are preserved.
Changes
stopRunningProfiler, with a discard option for quota denials.Test instructions
Run the existing profiler suite, which covers stop/start, visibility changes, session renewal, and quota checks:
Verified locally: all 39 tests pass; formatting and lint pass. No manual sandbox or staging test was performed.
Checklist