Repository navigation
📝 Document the WebSocket resource event generated from WebSocket vitals - #5294
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bdibon
marked this pull request as ready for review
November 17, 2026 12:51
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mariedm
approved these changes
Nov 17, 2026
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 16fdd38 | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
More details
The documentation is consistent with the WebSocket implementation and existing tests: WebSocket vitals reach beforeSend, while backend-generated resource events bypass it.
🤖 Bits Code Review · Commit 16fdd38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When
betaTrackWebSocketsis enabled, the Datadog backend uses the WebSocket vitals to generate a RUM resource event (resource.type: 'websocket') for each connection. The option's TSDoc doesn't say so, and it doesn't say that this event never reachesbeforeSend.Changes
Update the TSDoc comment of the
betaTrackWebSocketsoption (packages/browser-rum-core/src/domain/configuration/configuration.ts) to:websocketresource event from the WebSocket vitalsbeforeSendhookThis PR only changes a comment.
Test instructions
Nothing to test. Check the comment wording and that the link works.
Rendered with
yarn build:docs:html(RumInitConfigurationpage of@datadog/browser-rum):Checklist
🤖 Generated with Claude Code