Skip to content

⚗️ Remove the composed_path_selector_attributes experimental flag - #5231

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
luiz.barreto/remove-composed-path-selector-attributes-flag
Nov 17, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
luiz.barreto/remove-composed-path-selector-attributes-flag

Conversation

@LFBarreto

@LFBarreto LFBarreto commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

The composed_path_selector_attributes experimental flag gated the attribute enrichment of composed_path_selector. We want this behavior on by default for composed_path_selector, so the extra flag is no longer necessary.

Changes

  • Remove ExperimentalFeature.COMPOSED_PATH_SELECTOR_ATTRIBUTES.
  • getComposedPathSelector now always:
    • collects the maskable attributes (href on <a>, aria-label, name, title, alt, data-*) when the privacy level does not mask them,
    • drops the form action attribute (it can contain PII),
    • truncates between tokens, so it never splits an attribute key and value.
  • E2E: remove the flag from the masked attributes scenario.

Test instructions

  • yarn test:unit --spec packages/browser-rum-core/src/domain/getComposedPathSelector.spec.ts
  • yarn test:e2e -g "composed path selector"

Checklist

  • Tested locally (unit tests, typecheck, lint; E2E not run locally)
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

🤖 Generated with Claude Code

Always collect the unmasked maskable attributes, drop the form action and
truncate between tokens in composed_path_selector.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum Salesforce 192.62 KiB 192.41 KiB -216 B -0.11% ✅
Rum 192.60 KiB 192.38 KiB -216 B -0.11% ✅
Rum Salesforce Profiler 8.01 KiB 8.01 KiB 0 B 0.00% ✅
Rum Profiler 8.01 KiB 8.01 KiB 0 B 0.00% ✅
Rum Salesforce Recorder 32.62 KiB 32.62 KiB 0 B 0.00% ✅
Rum Recorder 32.62 KiB 32.62 KiB 0 B 0.00% ✅
Logs 60.22 KiB 60.15 KiB -72 B -0.12% ✅
Rum Slim 148.53 KiB 148.33 KiB -206 B -0.14% ✅
Worker 24.23 KiB 24.23 KiB 0 B 0.00% ✅
Rum Shopify 223.66 KiB 223.45 KiB -216 B -0.09% ✅
Rum Shopify Profiler 8.00 KiB 8.00 KiB 0 B 0.00% ✅
Rum Shopify Recorder 4.85 KiB 4.85 KiB 0 B 0.00% ✅

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 75.00%
• Overall Coverage: 78.14% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 40d8317 | Docs | View more details | Give us feedback!

…attributes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LFBarreto
LFBarreto marked this pull request as ready for review November 4, 2026 13:08
@LFBarreto
LFBarreto requested a review from a team as a code owner November 4, 2026 13:08

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The default-enabled attribute enrichment retains privacy masking, and form action URLs are excluded from selectors. Truncation preserves complete attribute tokens.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 574360c

@mormubis mormubis left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LFBarreto Actually, quick question: Would this follow the privacy levels of the user when collecting the composed path?

@mormubis
mormubis self-requested a review November 17, 2026 09:00
…omposed-path-selector-attributes-flag

# Conflicts:
#	packages/browser-core/src/tools/experimentalFeatures.ts
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit e415673 into main Nov 17, 2026
32 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the luiz.barreto/remove-composed-path-selector-attributes-flag branch November 17, 2026 14:29
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants