Repository navigation
⚗️ Remove the composed_path_selector_attributes experimental flag - #5231
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intoNov 17, 2026
Conversation
Always collect the unmasked maskable attributes, drop the form action and truncate between tokens in composed_path_selector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 40d8317 | Docs | View more details | Give us feedback! |
…attributes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LFBarreto
marked this pull request as ready for review
November 4, 2026 13:08
There was a problem hiding this comment.
More details
The default-enabled attribute enrichment retains privacy masking, and form action URLs are excluded from selectors. Truncation preserves complete attribute tokens.
🤖 Bits Code Review · Commit 574360c
mormubis
approved these changes
Nov 17, 2026
mormubis
reviewed
Nov 17, 2026
Contributor
There was a problem hiding this comment.
@LFBarreto Actually, quick question: Would this follow the privacy levels of the user when collecting the composed path?
mormubis
self-requested a review
November 17, 2026 09:00
mormubis
approved these changes
Nov 17, 2026
…omposed-path-selector-attributes-flag # Conflicts: # packages/browser-core/src/tools/experimentalFeatures.ts
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
luiz.barreto/remove-composed-path-selector-attributes-flag
branch
November 17, 2026 14:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
composed_path_selector_attributesexperimental flag gated the attribute enrichment ofcomposed_path_selector. We want this behavior on by default forcomposed_path_selector, so the extra flag is no longer necessary.Changes
ExperimentalFeature.COMPOSED_PATH_SELECTOR_ATTRIBUTES.getComposedPathSelectornow always:hrefon<a>,aria-label,name,title,alt,data-*) when the privacy level does not mask them,actionattribute (it can contain PII),Test instructions
yarn test:unit --spec packages/browser-rum-core/src/domain/getComposedPathSelector.spec.tsyarn test:e2e -g "composed path selector"Checklist
🤖 Generated with Claude Code