Repository navigation
Add bring-your-own OpenAI and Jev API keys - #94
Merged
Merged
Conversation
jerelvelarde
marked this pull request as ready for review
October 9, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visitors can now use their own OpenAI and Jev API keys instead of depending on the deployment's shared credentials. The chat header includes an API keys dialog with a real connection test, save, and clear actions. The agent also starts without shared keys for BYOK-only hosting.
Keys stay in browser memory until refresh or clear and are forwarded through the application server in request headers. Saving or clearing starts a new conversation; New chat retains the current keys. The backend scopes credentials across the full streaming request, isolates checkpoint IDs by credential pair, disables hosted LangSmith tracing for BYOK, and sanitizes provider errors. BYOK uses chat-latest and jev-latest, including internal agent model calls, without inheriting the host's OpenAI organization, project, or proxy settings.
Validation:
The application server receives visitor keys, so deployment operators must be trusted and credential headers must not be logged. This change is not deployed yet.
Security review fixes: streaming agent requests reject redirects to avoid forwarding credential headers; BYOK validation and Jev transports ignore environment proxy/CA settings; OpenAI clients discard inherited custom headers so server Authorization cannot override visitor keys. Regression tests exercise an actual cross-origin redirect and inspect synchronous/asynchronous OpenAI requests under poisoned host settings.