Skip to content

Deduplicate a Bot-formed memory per Bot, and keep forgetting person-wide #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chebaleomkar wants to merge 2 commits into
base: main
Choose a base branch
from
+10,014 −8
Open

Deduplicate a Bot-formed memory per Bot, and keep forgetting person-wide #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90cea80
test(memory): cover a fact formed by two Bots, forgetting and reset
Chebaleomkar Oct 14, 2026
f3f32e5
fix(memory): deduplicate a Bot-formed memory per Bot
Chebaleomkar Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Newest first. `Unreleased` is what is on `main` and not yet tagged.

## Unreleased

**Before upgrading.** Five things change for an existing deployment:
**Before upgrading.** Six things change for an existing deployment:
- A hosted computer's browser is now headed by default. It uses a little more memory than headless
did; set `COMPUTER_BROWSER_MODE=headless` (Helm: `computers.browserMode: headless`) to keep the old
behaviour.
Expand All @@ -31,6 +31,18 @@ Newest first. `Unreleased` is what is on `main` and not yet tagged.
- Migration `0056_sign_in_code_step` widens the check on `sign_in_requests.status` to allow
`code_required` (below). A server and a computer must be upgraded together: an older computer has
no `/sign-in/code`.
- Migration `0057_memory_dedup_per_bot` rebuilds one unique index on `personal_memories` to include
the Bot that formed the memory (below). It keeps every row. While it rolls out, a server still on
the previous release fails to save a newly formed Bot memory until it is replaced; nothing else is
affected.

### Each Bot keeps a fact it formed, even when another Bot formed it first

A memory a Bot forms from what it read was deduplicated per person, but each Bot recalls only the
memories it formed itself. So when a second Bot formed a fact the first already held, it was told
the fact was remembered and could then never recall it. Each Bot now keeps its own copy, and
resetting one Bot leaves the other's alone. Forgetting stays the person's: a fact forgotten from any
Bot is not formed again by another.

### Bot turns hold their conversation more carefully

Expand Down
2 changes: 2 additions & 0 deletions server/drizzle/0057_memory_dedup_per_bot.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
DROP INDEX "personal_memories_formed_digest_idx";--> statement-breakpoint
CREATE UNIQUE INDEX "personal_memories_formed_digest_idx" ON "personal_memories" USING btree ("owner_user_id","formed_by_agent_id","import_digest") WHERE "personal_memories"."formed_by" = 'bot';
Loading