Skip to content

Fix default values - #503

Open
lgmu wants to merge 6 commits into
ConSol-Monitoring:mainfrom
lgmu:fix-default-values
Open

lgmu wants to merge 6 commits into
ConSol-Monitoring:mainfrom
lgmu:fix-default-values

Conversation

@lgmu

@lgmu lgmu commented Nov 20, 2026

Copy link
Copy Markdown
Contributor
  • some default values were set differently in the code than the snclient.ini suggested
  • added testcase to notice this in the future

@lgmu
lgmu requested a review from sni November 20, 2026 14:59
Comment thread pkg/snclient/config.go Resolved
Comment thread pkg/snclient/config.go Resolved
Comment thread pkg/snclient/snclient.go
config.Section("/settings/default").MergeData(DefaultListenHTTPConfig)
config.Section("/settings/default").MergeData(DefaultHTTPClientConfig)
config.Section("/settings/system/default").MergeData(DefaultSystemTaskConfig)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we have the same 3 lines in test and app code and must never forget to keep them in sync. Also not cool :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants