Repository navigation
AzureDocumentDB: register Mongo conventions once per record type - #68
Merged
adamsitnik merged 1 commit intoOct 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses the registry leak, includes regression coverage, and follows provider versioning requirements.
0 open findings
What changed in this PR
Registers MongoDB conventions once per record type, preventing unbounded registry growth.
Changes:
- Moves convention registration to the generic mapper’s static constructor.
- Adds regression coverage.
- Bumps the provider version to 1.0.2.
| File | Description |
|---|---|
MongoMapper.cs |
Registers conventions once per record type. |
DocumentDBCollectionTests.cs |
Verifies repeated collection creation does not add conventions. |
AzureDocumentDB.csproj |
Bumps the package patch version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
adamsitnik
approved these changes
Oct 12, 2026
adamsitnik
left a comment
adamsitnik
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for your contribution @Empiree !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MongoMapper registered its conventions in the constructor, so every new collection added one more entry to ConventionRegistry. Now it happens once in a static constructor, same as in mongodb/mongo-mevd-provider#9
Added a test that creates a few collections and checks number of conventions doesnt change. It fails before the fix and passes after. Also bumped the provider version to 1.0.2
Fixes #64