Repository navigation
Guard hybrid search against IncludeVectors with embedding generation - #67
Merged
adamsitnik merged 1 commit intoOct 12, 2026
Conversation
Qdrant, Weaviate and Azure AI Search hybrid search (and Azure AI Search vector search) lacked the check that SearchAsync performs in other providers. Generated vectors can't be mapped back onto the source property, so throw NotSupportedException instead of failing during deserialization. Bump the affected provider versions to 1.0.1 and add unit tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a00fadae-dd58-4131-8f39-3e1a3b6bc005
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The guards are consistent with existing providers, adequately tested, and accompanied by required version updates.
0 open findings
What changed in this PR
Adds consistent IncludeVectors guards when embedding generation is configured.
Changes:
- Guards search and hybrid search across three providers.
- Adds provider-specific regression tests.
- Bumps affected packages to 1.0.1.
| File | Description |
|---|---|
MEVD/src/AzureAISearch/AzureAISearchCollection.cs |
Adds search guards. |
MEVD/src/AzureAISearch/AzureAISearch.csproj |
Bumps version to 1.0.1. |
MEVD/src/Qdrant/QdrantCollection.cs |
Adds hybrid-search guard. |
MEVD/src/Qdrant/Qdrant.csproj |
Bumps version to 1.0.1. |
MEVD/src/Weaviate/WeaviateCollection.cs |
Adds hybrid-search guard. |
MEVD/src/Weaviate/Weaviate.csproj |
Bumps version to 1.0.1. |
MEVD/test/AzureAISearch.UnitTests/AzureAISearchHybridSearchEmbeddingGenerationTests.cs |
Tests both guarded search paths. |
MEVD/test/AzureAISearch.UnitTests/AzureAISearch.UnitTests.csproj |
Links shared embedding generator. |
MEVD/test/Qdrant.UnitTests/QdrantHybridSearchEmbeddingGenerationTests.cs |
Tests both guarded search paths. |
MEVD/test/Qdrant.UnitTests/Qdrant.UnitTests.csproj |
Links shared embedding generator. |
MEVD/test/Weaviate.UnitTests/WeaviateHybridSearchEmbeddingGenerationTests.cs |
Tests both guarded search paths. |
MEVD/test/Weaviate.UnitTests/Weaviate.UnitTests.csproj |
Links shared embedding generator. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #66.
SearchAsync/HybridSearchAsyncmust throwNotSupportedExceptionwhenIncludeVectors = trueand an embedding generator is configured (vectors can't be returned for generated embeddings). Several providers were missing this guard.Fixes
HybridSearchAsyncHybridSearchAsyncSearchAsyncandHybridSearchAsync(previouslySearchAsyncfailed with aNullReferenceException)Tests
Audit of the other providers: Chroma, PgVector, SqlServer already have the guard; Redis resolves generators before validating.