Repository navigation
Conversation
posthog-js is_capturing() returns true under cookieless_mode always before it checks respect_dnt, so DNT and GPC visitors were still tracked. Skip posthog.init, the error listeners and pageviews when the browser opts out, and drop events in before_send as a second guard.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
biggest-littlest
approved these changes
Nov 18, 2026
biggest-littlest
left a comment
Member
There was a problem hiding this comment.
Same diff CodeRabbit reviewed clean on #144.
ALARGECOMPANY
approved these changes
Nov 18, 2026
ALARGECOMPANY
left a comment
Member
There was a problem hiding this comment.
Same diff CodeRabbit reviewed clean on #144.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote #144 from dev: visitors whose browser sends Do Not Track or Global Privacy Control now skip PostHog entirely. posthog-js 1.447.2 treats
cookieless_mode: "always"as capturing before it checksrespect_dnt, so the site checks the signals itself, beforeposthog.initand again inbefore_send.#144 passed verify, and CodeRabbit had no actionable comments. Locally, check, build, Qlty and the PostHog unit, contract and browser tests (37/37) pass. The only other commit is a merge of main that changes no files.