Skip to content

chore(release): promote dropping Systema's field-notes example - #127

Merged
scttbnsn merged 79 commits into
mainfrom
dev
Nov 2, 2026
Merged

scttbnsn merged 79 commits into
mainfrom
dev

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Promotes #126 to main, which reverts #124: Systema goes back to no "Specimen in use" box. dev's tree matches #126; the reconcile commit only records main as merged.

Summary by CodeRabbit

  • Changes
    • Specimen excerpts are now attributed to “README.”
    • The “systema-machinae” example no longer appears in specimen field notes.

biggest-littlest and others added 30 commits August 15, 2026 18:45
…stion (#52)

PostHog's cookieless server-hash step reads $raw_user_agent and $host
straight off event.properties and drops the event with a
cookieless_missing_user_agent/cookieless_missing_host ingestion warning
if either is absent. createCommonProperties rebuilt an allowlisted
properties object that dropped both, so every event was silently
discarded at ingestion. Forward them through; never add $ip, which
PostHog's capture service fills in server-side from the connection.

Co-authored-by: scttbnsn <80784472+scttbnsn@users.noreply.github.com>
* fix(analytics): promote cookieless ingestion fix to production (#53)

PostHog's cookieless server-hash step reads $raw_user_agent and $host
straight off event.properties and drops the event with a
cookieless_missing_user_agent/cookieless_missing_host ingestion warning
if either is absent. createCommonProperties rebuilt an allowlisted
properties object that dropped both, so every event was silently
discarded at ingestion. Forward them through; never add $ip, which
PostHog's capture service fills in server-side from the connection.

Co-authored-by: biggest-littlest <zap_inane.2p@icloud.com>

* chore(config): drop the stale Cursor rules folder

* docs(config): drop dangling .cursorrules references

---------

Co-authored-by: biggest-littlest <zap_inane.2p@icloud.com>
Measured over the shared PostHog project, 208 of 432 sessions across
the five instrumented sites record zero duration, and PostHog's
built-in Web analytics Page/Entry page/Exit page tables return zero
rows. capture_pageleave was false, so a session's last recorded
timestamp is its last pageview, and a five-minute read of one page
scores as zero seconds.

Flipping the option alone fixes nothing: sanitizeEvent allowlisted
only $pageview, cta activated, and $web_vitals, so every $pageleave
posthog-js emitted would have been dropped silently with no error and
no ingestion warning. This adds a $pageleave branch that rebuilds the
event the same way $pageview does. capture_pageview is false here
(pageviews are captured by hand), so posthog-js's
_shouldCapturePageleave gate needs an explicit true rather than the
default.

$pathname is the property PostHog's page tables actually key off, and
it was never sent. It's bound to the already-sanitized `path` value,
never the raw pathname, so it can't carry a route outside
ALLOWED_ROUTES and adds no information the event wasn't already
sending. A regression test asserts the two never diverge.

No privacy option changes: cookieless_mode, person_profiles,
persistence, disable_persistence, respect_dnt, save_referrer, and
save_campaign_params are untouched.

Part of X16 in the ops execution plan.
- fix(seo): point Organization.logo at /icon-512x512.png; the referenced
  /logos/codeswhat-logo-green.png never existed, so crawlers got a 404
- fix(seo): strip trailing slashes from BASE_URL and reuse it in robots.ts
  and sitemap.ts, so a NEXT_PUBLIC_SITE_URL set with a trailing slash can't
  emit //sitemap.xml-style URLs
- chore(seo): disallow /studio/ in robots.txt; the capture pages already
  404 in production but the exclusion shouldn't depend on that guard
- chore(seo): 308 the stable *.vercel.app production aliases to
  codeswhat.com instead of serving duplicate content
- fix(api): stop forwarding EmailOctopus error detail to subscribe clients;
  log it server-side and return a fixed message
One-line range bump; npm resolves next 16.3.3, which also pulls the
patched transitive versions: postcss 8.5.23, nanoid 3.3.18, sharp 0.35.4.
npm audit now reports zero vulnerabilities. No code changes needed: the
app has no middleware, rewrites, server actions, CSP nonces, or
next/image usage, so none of the fixed CVEs required app-side work.
- build(deps): pick up the root-params.d.ts reference next 16.3 adds
- ci(hooks): pass --no-errors-on-unmatched to the biome pre-commit job so
  committing only biome-ignored files (like next-env.d.ts) doesn't fail
It was covered only by .git/info/exclude, which protects one clone and nobody else's. Without a tracked line, `git add -A` in the parent stages a nested worktree as an embedded gitlink and `git clean -ffd` deletes it.
… bounded UTM labels (#68)

* fix(analytics): set $pathname on web vitals from the sanitized path

* feat(analytics): add project CTA, newsletter and client error events

* feat(analytics): record campaign labels through a bounded UTM vocabulary
* fix(analytics): set $pathname on web vitals from the sanitized path

* feat(analytics): add project CTA, newsletter and client error events

* feat(analytics): record campaign labels through a bounded UTM vocabulary

* feat(site): add /support page with GitHub Sponsors, Stripe tiers and supporters list

Six tiers mirror GitHub Sponsors and Stripe, with links read only from
CODESWHAT_SUPPORT_LINKS. Support clicks go through the existing PostHog
sanitizer under the support placement, and /support joins the route allowlist.

* feat(site): replace the 3D scene design with the Catalogue design

Homepage, /projects/<slug> specimen pages and /support now use the Catalogue
shell, sprites and fonts. One light/dark theme via the nonce'd init script.
Drops the WebGL scene from the shipped routes and the Tailwind/shadcn
layer; three stays only for the dev-only /studio capture tools.

* fix(site): replace the old tagline and em dashes in site copy

* feat(site): render Catalogue share cards for every page

* fix(site): match the share-card wordmark to the site header

* fix(site): drop the wind-down policy from the support page

* style(site): remove the unused notice signature rule

* fix(site): make the homepage support section a plain ask
# Conflicts:
#	frontend/app/layout.tsx
#	frontend/test/site-browser.test.mjs
Next 16.3.3 -> 16.4.3 (critical: image optimization SSRF, SSG/ISR cache poisoning), dompurify 3.4.13 -> 3.4.17 via posthog-js (critical), sharp 0.35.4 -> 0.35.5 (high), plus transitive lockfile patches. npm audit --omit=dev is clean on this head. CodeRabbit review delivered with no actionable comments; verify and Vercel preview green.
…the roadmap (#73)

- ci(website): run support contracts and stop duplicate verify runs
- ci(website): stop persisting the checkout credential
- ci(website): verify fork branches named dev
- ci(website): pin workflow actions to immutable revisions
- ci(website): give push runs a unique concurrency group
- refactor(repo): remove the stray portfolio app, old launcher and log junk
- docs(roadmap): record the 2026-10-25 status and retire the superseded 3D items

Review: Codex (two P2s, one fixed in-branch, one recorded as no-action) and CodeRabbit (no actionable comments). verify and Vercel preview green on f3ea2d7.
- test(analytics): resolve posthog-core by package specifier and fail clearly if an upgrade drops PostHog#_runBeforeSend
- test(analytics): replace the stale body check in the production browser contract; require real Flight scripts before excluding them
- docs(deploy): run the browser contract after each promotion
- docs(roadmap): record the #72 and #73 promotion to production

Two CodeRabbit passes: one finding on the first (Flight-script filter too loose), fixed in 2801dc4; none on the second. verify and Vercel green on 2801dc4. Browser contract 1/1 against https://codeswhat.com.
scttbnsn and others added 26 commits October 31, 2026 18:01
* feat(subscribe): verify signups with Cloudflare Turnstile

Render an interaction-only widget in the footer form, load its script on first touch, and send the response with the email. The route verifies it with siteverify after validation and the rate limit, fails closed with 503, and pins the hostname in production. CSP admits only challenges.cloudflare.com for script and frame.

* fix(subscribe): harden the Turnstile load path and report a missing response as 422

A missing response now returns 422 with a refresh message and its own analytics class, 403 gets one too. The script load has a 15s deadline and clears its cache on every failure, a render error or unmount no longer wedges retries, and the interactive wait is 120s.
* docs(roadmap): drop shipped items and stale deployment notes

Trim the public roadmap to open work, and correct the Vercel guide: production is the only deployment target, and the support-page cost note is gone.

* docs(roadmap): drop a leftover update automation line

* docs(vercel): restore blank line before a heading
* docs(vercel): list the EmailOctopus timeout as a 503 cause

* docs(vercel): note EmailOctopus can return a 503 itself
…erify (#113)

The browser suite now takes BROWSER_ENGINE (chromium, firefox, webkit) and test:browser:all runs each in turn. The verify job drops its promotion-PR skip so a skipped job can no longer satisfy the required check.
Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-node](https://github.com/actions/setup-node).


Updates `actions/checkout` from 4.4.0 to 7.0.1
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@11d5960...3d3c42e)

Updates `actions/setup-node` from 4.4.0 to 7.1.0
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@49933ea...949feb2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 7.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/setup-node
  dependency-version: 7.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The clock tests load with domcontentloaded and filled the email before React hydrated the form. The value never reached state, so the submit failed validation with an empty address and the expected alert or success text never appeared. Waiting for React's props marker on the input makes the three page.clock tests deterministic on Linux WebKit.
Bumps react 19.3.1, typescript 7.0.2, @biomejs/biome 2.6.4, three 0.186, playwright-core 1.64.1, posthog-js 1.442.1 and the rest of the npm group. Migrates biome.json, passes href explicitly in TrackedCtaLink so the anchor is recognised as keyboard-activatable, excludes the generated favicon-green.svg (embedded PNG, no place for a title), and updates the audited PostHog pin test.
* fix(signup): submit what the visitor typed before hydration

The email input is controlled by state, so text typed before React hydrated never reached it and submit reported an invalid address while the value was visible. Read both fields from the form on submit and sync them into state on mount.

* test(workflow): skip comment lines when extracting on: and job blocks

A column-zero comment ended the capture early, so a later paths filter could escape the guard. Add a self-test with an inline fixture.
Moves the audited PostHog pin with it. 1.443.0 only changes the hosted and local snippet loaders, which this site doesn't use; it initializes from the npm package.
)

The fin's bottom edge sat on a second row of outline. The fin now fills one row lower and ends in one black edge, and the home and Drydock share cards are regenerated.
Quote the MCP lines from its public agents.md notice. The source has no
repo to pin, so the entry carries a sourceName and the attribution reads
agents.md notice instead of README. Other entries render as before.
Systema is a site you visit and watch, so the MCP line read as its main use when it's a side feature. Systema goes back to no usage box; reverts #124.
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between f735e4d and d04f84d.

Files selected for processing: 3
  • frontend/app/(site)/projects/[slug]/page.tsx
  • frontend/lib/specimen-examples.ts
  • frontend/test/site-browser.test.mjs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The specimen example type no longer includes a source name, and the Systema Machinae example was removed. The project page now labels displayed excerpt sources as “README.” The browser test checks that Systema has no specimen entry.

Changes

Specimen example source behavior

Layer / File(s) Summary
Catalog, attribution, and browser assertion
frontend/lib/specimen-examples.ts, frontend/app/(site)/projects/[slug]/page.tsx, frontend/test/site-browser.test.mjs
The SpecimenExample type no longer includes sourceName, and the Systema Machinae entry was removed. The page always labels excerpt sources “README.” The browser test expects no “Specimen in use” entry for Systema.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: biggest-littlest, alargecompany

Merge Risk: Minimal · up to d04f8

No actionable merge-blocking risk is identified in this focused removal. Merge after normal checks pass.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: promoting the removal of Systema’s field-notes example.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Biome (2.5.15)
frontend/app/(site)/projects/[slug]/page.tsx

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

frontend/lib/specimen-examples.ts

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

frontend/test/site-browser.test.mjs

Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@biggest-littlest biggest-littlest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: verify green on d04f84d on all three engines; CodeRabbit reviewed it with no actionable comments.

@ALARGECOMPANY ALARGECOMPANY left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: verify green on d04f84d on all three engines; CodeRabbit reviewed it with no actionable comments.

@scttbnsn
scttbnsn merged commit 74056d4 into main Nov 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants