Repository navigation
Cape Town | 26-ITP-Sept | Vaidah Simenti | Sprint 3 | Refactoring Dead Code - #1727
Open
Vaidah-dev wants to merge 2 commits into
Open
Vaidah-dev wants to merge 2 commits into
Vaidah-dev wants to merge 2 commits into
Conversation
Vaidah-dev
added
the
Needs Review
madhuranakate
added
Review in progress
madhuranakate
suggested changes
Oct 21, 2026
| // The sayHello function should continue to work for any reasonable input it's given. | ||
|
|
||
| let testName = "Jerry"; | ||
| const greeting = "hello"; |
There was a problem hiding this comment.
is this variable name clashing with another ?
Author
There was a problem hiding this comment.
Oh yes, the parameter 'greeting' was shadowing the global, i have removed the global variable completely and passed "hello" directly into the clash.
| } | ||
|
|
||
| testName = "Aman"; | ||
| let testName = "Aman"; |
There was a problem hiding this comment.
Its correct that you removed the previous testName but if you are not overriding testName, is let necessary ?
Author
There was a problem hiding this comment.
You are right, since i removed the reassignment, the value never changes so i guess 'const' is the correct choice.
madhuranakate
added
Reviewed
Vaidah-dev
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
[X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[X] My changes meet the requirements of the task
[X] I have tested my changes
[X] My changes follow the style guide
Task code
CYF-1066
Changelist
Exercise 1
Removed const greetingStr (redundant because the function built a string it never used)
Removed console.log(greetingStr) (unreachable because it is placed after return)
Removed initial testName = "Jerry" (redundant because it is overwritten before use)
Exercise 2
Removed const capitalisedPets (redundant because it is computed but never used)
Removed logPets function (unreachable because it is never called)