London | 26-ITP-Sep | Diana Ausiejute | Sprint 2 | Practice TDD by ausiejute · Pull Request #1712 · CodeYourFuture/Module-Structuring-and-Testing-Data

ausiejute · 2026-10-15T10:05:33Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1060

Changelist

Implemented functions and wrote required tests in Jest for 'Count', 'Repeat string' and 'Get ordinal number' exercises.

hackertainment

Thank you for your coursework. Please keep it up.

hackertainment · 2026-10-19T15:27:58Z

 test("should count multiple occurrences of a character", () => {
  const str = "aaaaa";
  const char = "a";
  const count = countChar(str, char);
  expect(count).toEqual(5);
 });


This is a special case of str where it is all the char to count. Would it still count correctly if the char just exists in some part of the str?

This proves i still have a long way to go in developing an eye for detail when looking at code

hackertainment · 2026-10-19T15:28:15Z

+test("should count zero occurrences of a character", () => {
+  const str = "aaaa";
+  const char = "b";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});


There is a special str that would give 0 anyway. Please add that test case as well. Thank you.

hackertainment · 2026-10-19T15:30:30Z

+test("should append 'th' for the rest of the numbers", () => {
+  expect(getOrdinalNumber(9)).toEqual("9th");
+  expect(getOrdinalNumber(20)).toEqual("20th");
+  expect(getOrdinalNumber(108)).toEqual("108th");
+});


Lines 13-15 of your code has not been included in this test suite. Please add test cases specifically for that part of the code. Thank you.

I see you have added 11th, 12th, and 13th. Just it would be better to also include 3-digit number (e.g. 211th, 112th, and 213) ended in 11 or 12 or 13 as well. I will let you pass this time because your code is correct, but please improve test cases coverage in the future. Thank you.

hackertainment · 2026-10-19T15:35:45Z

+  if (Number.isInteger(count) && count < 0) {
+    throw new Error(`Invalid input`);
+  }


I don't think this part is accurate. Consider count = 4.5, would the result be the same as expected?

Thanks for that! You got me reading about the distinction between the tasks where one is required to take what's given and implement to handle only specific cases, and where one has to handle edge cases, validate inputs, throw errors for invalid.. . If the task required me to 'Handle edge cases' or, more specifically, 'handle non-integers', then it would be a must to rewrite my implementation and add a test accordingly. I would change that part into if (!Number.isInteger(count) || count < 0) { throw new Error(Invalid input); }

hackertainment · 2026-10-19T15:36:24Z

 test("should repeat the string count times", () => {
  const str = "hello";
  const count = 3;
  const repeatedStr = repeatStr(str, count);
  expect(repeatedStr).toEqual("hellohellohello");
 });

 // Case: handle count of 1:
 // Given a target string `str` and a `count` equal to 1,
 // When the repeatStr function is called with these inputs,
 // Then it should return the original `str` without repetition.

+test("should repeat the string 1 time", () => {
+  const str = "hello";
+  const count = 1;
+  const repeatedStr = repeatStr(str, count);
+  expect(repeatedStr).toEqual("hello");
+});
+
 // Case: Handle count of 0:
 // Given a target string `str` and a `count` equal to 0,
 // When the repeatStr function is called with these inputs,
 // Then it should return an empty string.

+test("should repeat the string 0 times", () => {
+  const str = "hello";
+  const count = 0;
+  const repeatedStr = repeatStr(str, count);
+  expect(repeatedStr).toEqual("");
+});


Your test cases are correct. Just for you to think a little bit more, besides const str = "hello", what special string should also be added to each of the test cases?

An empty string, thank you:)

hackertainment · 2026-10-20T22:15:23Z

Congratulation, you have completed this PR successfully.

ausiejute added 3 commits October 14, 2026 13:26

Write an implementation and tests for Counting task

831c151

Implement and write tests for Repeat String task

0f801bb

Write tests and implement the function for Get Ordinal Number task

714b6fa

ausiejute added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 15, 2026

hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 19, 2026

hackertainment reviewed Oct 19, 2026

View reviewed changes

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 19, 2026

hackertainment mentioned this pull request Oct 19, 2026

Get Code Review and Iterate hackertainment/My-Coursework-Planner#8

Open

ausiejute added 4 commits October 20, 2026 12:05

Add a test for an empty input

780bc1c

Add a missing test for 11-13th floor

93fb568

Add a more specific test for multiple occurences of a character

aebac3e

Add a test for a case of an empty string input

005c578

ausiejute added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 20, 2026

ausiejute requested a review from hackertainment October 20, 2026 13:35

Navigation Menu

Repository navigation

London | 26-ITP-Sep | Diana Ausiejute | Sprint 2 | Practice TDD - #1712

London | 26-ITP-Sep | Diana Ausiejute | Sprint 2 | Practice TDD#1712
ausiejute wants to merge 7 commits into
CodeYourFuture:mainfrom
ausiejute:coursework/sprint-2-practice-tdd

ausiejute commented Oct 15, 2026

Uh oh!

hackertainment left a comment

Uh oh!

hackertainment Oct 19, 2026

Uh oh!

ausiejute Oct 20, 2026

Uh oh!

hackertainment Oct 19, 2026

Uh oh!

hackertainment Oct 19, 2026

Uh oh!

hackertainment Oct 20, 2026 •

edited

Loading

Uh oh!

hackertainment Oct 19, 2026

Uh oh!

ausiejute Oct 20, 2026

Uh oh!

hackertainment Oct 19, 2026

Uh oh!

ausiejute Oct 20, 2026

Uh oh!

hackertainment commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ausiejute commented Oct 15, 2026

Learners, PR Template

Task code

Changelist

Uh oh!

hackertainment left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hackertainment Oct 20, 2026 •

edited

Loading