Skip to content

Manchester | 26-ITP-Sep | Rahana Suleiman | Sprint 3 | Refactoring Dead Code #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahanasuleiman8-ship-it wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-Sep | Rahana Suleiman | Sprint 3 | Refactoring Dead Code #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f3450d
add fizzbuzz function and corresponding tests
rahanasuleiman8-ship-it Oct 12, 2026
b735c48
remove unreachable and redundant code from exercise-1.js
rahanasuleiman8-ship-it Oct 15, 2026
47af83e
remove unused code and comments from exercise-2.js
rahanasuleiman8-ship-it Oct 15, 2026
f4344f1
chore: remove accidental files from other sprints
rahanasuleiman8-ship-it Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions dead-code/exercise-1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,28 @@
// Find the instances of unreachable and redundant code - remove them!
// The sayHello function should continue to work for any reasonable input it's given.

let testName = "Jerry";
// let testName = "Jerry";
Comment thread
rahanasuleiman8-ship-it marked this conversation as resolved.
// const greeting = "hello";

// function sayHello(greeting, name) {
// const greetingStr = greeting + ", " + name + "!";
// return `${greeting}, ${name}!`;
// console.log(greetingStr);
// }

// testName = "Aman";

// const greetingMessage = sayHello(greeting, testName);

// console.log(greetingMessage); // 'hello, Aman!'

const greeting = "hello";
const testName = "Aman";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";

const greetingMessage = sayHello(greeting, testName);

console.log(greetingMessage); // 'hello, Aman!'
34 changes: 28 additions & 6 deletions dead-code/exercise-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,36 @@
// Remove the unused code that does not contribute to the final console log
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

// const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];

@webmonch webmonch Oct 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as in exercise 1.

// const capitalisedPets = pets.map((pet) => pet.toUpperCase());
// const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

// function logPets(petsArr) {
// petsArr.forEach((pet) => console.log(pet));
// }

// function countAndCapitalisePets(petsArr) {
// const petCount = {};

// petsArr.forEach((pet) => {
// const capitalisedPet = pet.toUpperCase();
// if (petCount[capitalisedPet]) {
// petCount[capitalisedPet] += 1;
// } else {
// petCount[capitalisedPet] = 1;
// }
// });
// return petCount;
// }

// const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);

// console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log


const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}

function countAndCapitalisePets(petsArr) {
const petCount = {};

Expand All @@ -25,4 +47,4 @@ function countAndCapitalisePets(petsArr) {

const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);

console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log
console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 }
Loading