London | 26 ITP SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests by russom-g · Pull Request #1700 · CodeYourFuture/Module-Structuring-and-Testing-Data

russom-g · 2026-10-13T20:29:55Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1059

Changelist

Functions implemented. Tests written with node and jest.

hackertainment

Thank you for your coursework. Just an additional note: a decimal number itself is a fraction, but decimal fraction may not be well defined without simplified into integer fraction in mathematics. Therefore, I will let you pass this time as this is a programming exercise but not a mathematics course (and you did return the results correctly if I calculate their integer form on my own).

hackertainment · 2026-10-19T15:42:35Z

+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Straight angle";
+  } else if (angle > 180 && angle <= 360) {


May possibly be just a typo, but read line 10 of the question carefully and please fix your code as well. Thank you.

Thanks for the review and feedback.

= sign is removed from reflex angle if condition statement.

hackertainment · 2026-10-19T15:43:47Z

+  const Reflex2 = getAngleType(360);
+  assert.equal(Reflex2, "Reflex angle");


This looks not quite correct to me, and please fix it as well. Thank you.

Its changed to 359.

Hmm... you would also need to change the boundary case of invalid angle as well.

hackertainment · 2026-10-19T15:44:32Z

+test(`should return "Reflex angle" when (180 > angle <= 360)`, () => {
+  expect(getAngleType(181)).toEqual("Reflex angle");
+  expect(getAngleType(299)).toEqual("Reflex angle");
+  expect(getAngleType(360)).toEqual("Reflex angle");


This line looks not quite correct to me, and please fix it as well. Thank you.

It'a changed to 359.

Hmm... you would also need to change the test description and the boundary case of invalid angle as well.

hackertainment · 2026-10-19T15:47:11Z

+test("Negative numerator proper fraction", () => {
+  assert.equal(isProperFraction(-9, 1), true);
+});


this one should return false, please fix it, thank you.

hackertainment · 2026-10-19T15:47:32Z

+test("Both negative proper fraction", () => {
+  assert.equal(isProperFraction(-7, -3), true);
+});


this one should return false, please fix it, thank you.

Thank you. For both negative numerator and denominator, you have included (-4, -4) and (-7, -3), but how about (-3, -7) where the "result" is a positive number?

hackertainment · 2026-10-19T15:49:49Z

+test(`should return true for negative proper fraction`, () => {
+  expect(isProperFraction(-7, -3)).toEqual(true);
+});


this one should return false, please fix it, thank you.

Thank you. For both negative numerator and denominator, you have included (-4, -4) and (-7, -3), but how about (-3, -7) where the "result" is a positive number?

hackertainment · 2026-10-19T15:49:56Z

+test(`should return true for negative numerator proper fraction`, () => {
+  expect(isProperFraction(-9, 1)).toEqual(true);
+});


this one should return false, please fix it, thank you.

Done.

The reason I included negative fraction is the requirement didn't say no negative numbers. Secondly I checked online and I read that negative numbers can be proper fraction.

Yes, negative numbers can be proper fraction if (without the negative sign) the numerator is smaller than the denominator. As a result, both (-1, 9) and (1, -9) should return true but (-9, 1) and (9, -1) should return false. The issue here is inconsistency. Either consistently treating end result between -1 and 0 as true if negative numbers can be proper fraction, or consistently treating all negative "result" as false if negative numbers cannot be proper fraction.

p.s.: for this question, you have to handle negative numbers even the question didn't mentioned it.

hackertainment · 2026-10-19T15:53:46Z

I don't think this program is completely correct. Consider card = "AA", would the result be the same as expected?

I added suits and validSuits variables to fix the bug.

Many thanks

Much better now.

hackertainment · 2026-10-20T21:51:03Z

Thank you for your effort. You are almost there, and just remain the following new comments:

London | 26 ITP SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests #1700 (comment)
London | 26 ITP SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests #1700 (comment)
London | 26 ITP SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests #1700 (comment)
London | 26 ITP SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests #1700 (comment)
London | 26 ITP SEP | Russom Gebremeskel | Sprint 2 | Implement and Rewrite Tests #1700 (comment)

russom added 30 commits September 28, 2026 14:46

List edge cases for test.

301ea63

Update list.

2501561

Add an if condition to check midnight

63e477b

Add another case to test midnight

a8e1b2d

Add test case 00:01 to 12:01 am

9e2cef8

Add condition for checking midday 12 pm

2ba2e34

Add test case for 01:00 to 01:00 am

06d5f91

Add test case for 11:59 to 11:59 am

3dc6da6

Add test case for 12:01 to 12:01 pm

1e6cb55

Add test case for 13:00 to 1:00 pm

61b2ce7

Add test case fo 23:59 to 11:59 pm

0407869

Add padStart method to hours

06d3f9a

Add more description.

598f744

Add padStart method to convert 23:00 to 01:00pm

e6fde3b

Edit comments

c2f743c

Inline code directly into return statement

e7ff9c7

Change am and pm to lower case and update description.

751fb78

Unreachable code.

4707f5a

Remove unreachable and redundant code.

f504687

Remove unused code

d9197c4

Update function to work for any input.

9494c3d

Format code with prettier.

582699c

Stop tracking files

b806b41

Stop tracking files

fcf27e7

Restore files unrelated to this PR

04f544f

Add if condition for checking right angle.

4815e87

Write test for Acute angle.

9dc9e1f

Write test for Obtuse angle.

10b0d0f

Add if condition for checking Acute angle.

cccf002

Add if condition for checking Obtuse angle.

ed2729e

russom-g added 3 commits October 13, 2026 21:15

Fix spelling error.

3e40397

Fix spelling error.

ad4fae0

Format code with prettier.

b8ba7fd

This comment has been minimized.

Sign in to view

Restore dead-code files to match main

0c75ac6

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2026

This comment has been minimized.

Sign in to view

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2026

russom-g force-pushed the coursework/sprint-2-implement-and-rewrite branch from 7d498f5 to 0c75ac6 Compare October 13, 2026 22:08

hackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 19, 2026

hackertainment reviewed Oct 19, 2026

View reviewed changes

hackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 19, 2026

hackertainment mentioned this pull request Oct 19, 2026

Get Code Review and Iterate hackertainment/My-Coursework-Planner#8

Open

russom-g added 9 commits October 19, 2026 20:05

Remove = bug from reflex angle condition

fb40ba0

Update reflex angle test max limit to 359

2b13cd7

Update reflex angle test to 359

3dad527

Update test for negative numbers

dc6fa1d

Add if condition for checking negative numbers.

72cf361

Change test cases with negative numbers to return false.

533ec51

Add an array of suits to check for valid suits.

c3fd5c6

Add more test case for testing invalid card

2d476b1

Add more test case for testing invalid cards.

9cd8008

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 19, 2026

hackertainment removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 20, 2026

		const Reflex2 = getAngleType(360);
		assert.equal(Reflex2, "Reflex angle");

Conversation

russom-g commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Task code

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

hackertainment left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

russom-g Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hackertainment commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

russom-g commented Oct 13, 2026 •

edited

Loading

hackertainment Oct 20, 2026 •

edited

Loading

hackertainment Oct 20, 2026 •

edited

Loading

hackertainment Oct 20, 2026 •

edited

Loading

russom-g Oct 19, 2026 •

edited

Loading

hackertainment Oct 20, 2026 •

edited

Loading