Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
Mugs3
added
the
Needs Review
cjyuan
reviewed
Oct 19, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code looks good.
It seems you might have misunderstood the definition of proper fraction.
Comment on lines
+45
to
+50
| test(`should return "Invalid angle" when (angle === Invalid)`, () => { | ||
| // Test various invalid angles, including boundary cases | ||
| expect(getAngleType(361)).toEqual("Invalid angle"); | ||
| expect(getAngleType(0)).toEqual("Invalid angle"); | ||
| expect(getAngleType(-181)).toEqual("Invalid angle"); | ||
| }); |
Contributor
There was a problem hiding this comment.
-
"(angle === Invalid)" does not quite tell which angles are considered invalid.
-
0is a good boundary case to check. Could you think of the other boundary case?
Comment on lines
+20
to
+23
| // Special case: numerator is negative number | ||
| test(`should return true when denominator is 1`, () => { | ||
| expect(isProperFraction(-1, 1)).toEqual(false); | ||
| }); |
Contributor
There was a problem hiding this comment.
-1 / 1, which is equal to -1, is not a proper fraction.
Could you look up the definition of "proper fraction" and then update the tests and your function implementation?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task code
CYF-1059
Changelist
Uploaded implement and rewrite tests coursework