Cape Town | 26-ITP-Sept | Leigh Ross | Sprint 2 | Implement and rewrite tests by leigh-ross · Pull Request #1683 · CodeYourFuture/Module-Structuring-and-Testing-Data

leigh-ross · 2026-10-12T00:28:15Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1059

Changelist

Added 3 functions:

getAngleType
isProperFraction
getCardValue
Added node tests for each Function.
Rewrote node tests for jest.

Liam310 · 2026-10-13T16:18:10Z

@leigh-ross Hi Leigh! Great work overall on this coursework but I have left a few changes you need to look into. In general, you should always make sure to run your tests before committing - you don't want to be committing work that isn't passing tests!

A quick note on your commits: I really appreciate you committing once per function, I think that is a good practice for using commits to track when some unit of work is complete. The commit messages could use a little bit of improvement for you to consider in the future. I would try to write commit messages by stating what the commit will change if it is merged (I know we don't merge PRs at CYF, but in a workplace you would). Imagine they are following on from the phrase "this commit will...", for example instead of:

Angle type: Function logic works, added test cases, all tests pass

You could say

implement getAngleType function with full test suite

You don't need to make these changes as part of this PR but bear it in mind for future :)

…, Adapted test suites for node and jest to test the new logic correctly. All tests pass.

…< denominator

…dded error for both if conditions do not pass. Added tests in node and jest for the incorrect suit case and error throwing. All tests pass.

Liam310 · 2026-10-20T09:33:02Z

+  test("-980/100 is not a proper fraction", () => {
+    expect(isProperFraction(-98, 100)).toBe(false);
+  });


I'm afraid I'm still getting a failing test here! Looks like the assertion doesn't match the intention of the test perhaps...

I think it should be fixed now. My apologies for this back and forth.

don't apologise, that's what code review is for 🙂

Liam310 · 2026-10-20T14:51:02Z

@leigh-ross Excellent! All done 👌

leigh-ross added 4 commits October 12, 2026 00:17

Angle type: Function logic works, added test cases, all tests pass

50a495c

Proper fraction: added function logic, added test cases, all tests pass

b5a6757

Card value: added fucntion logic, added test cases, all tests pass

93ff60f

Copied over tests from node and rewrote as jest

6adba30

leigh-ross added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2026

Liam310 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 12, 2026

Liam310 reviewed Oct 12, 2026

View reviewed changes

Comment thread implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js

Liam310 reviewed Oct 12, 2026

View reviewed changes

Comment thread implement-and-rewrite-tests/implement/2-is-proper-fraction.js Outdated

Liam310 reviewed Oct 12, 2026

View reviewed changes

Comment thread implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js Outdated