Repository navigation
Release 1.5.0: validate the registry's server certificate - #55
Merged
Merged
Conversation
ValidateServerCertificate returned true for any certificate, so a man-in-the-middle could present its own certificate and read the EPP login credentials. Accept the certificate only when it chains to a trusted root and matches the host name. Add TcpTransport.ServerCertificateValidationCallback so test environments with self-signed certificates can supply their own check. This is a behavior change for such setups; bump to 1.5.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TcpTransport.ValidateServerCertificatereturnedtruefor every certificate, so a man-in-the-middle could present any certificate and capture the EPP login credentials (clID/password).sslPolicyErrors == SslPolicyErrors.None, meaning it chains to a trusted root, matches the host name and hasn't expired. This applies with and without a client certificate.TcpTransport.ServerCertificateValidationCallbackproperty. It lets test environments with self-signed certificates supply their own check, ideally pinning the expected certificate. It's a settable property rather than a new constructor parameter, so existing constructor calls stay compatible at both source and binary level.Testing
TcpTransportconnections on port 443:🤖 Generated with Claude Code