Repository navigation
Release 1.4.1: stop forcing TLS 1.0 when connecting with a client certificate - #54
Merged
Merged
Conversation
… 1.0 Service.Connect and ITransport.Connect defaulted to SslProtocols.Tls, which TcpTransport passes to AuthenticateAsClient whenever a client certificate is set, the path most registries require. Servers that only accept TLS 1.2+ reset the connection. Default to SslProtocols.None so the OS negotiates the best version; bump to 1.4.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Service.Connect()andITransport.Connect()defaulted toSslProtocols.Tls(TLS 1.0).TcpTransportpasses that value toAuthenticateAsClientwhenever a client certificate is configured, which is the path most registries require. Servers that only accept TLS 1.2+ reset the connection.SslProtocols.None, so the OS negotiates the best version. This also clears the SYSLIB0039 obsolete-TLS build warning.Callers that pass a protocol explicitly are unaffected. C# compiles default parameter values into the call site, so consumers need to recompile against 1.4.1 to pick up the new default.
Testing
TcpTransportwith a self-signed client certificate againstwww.nuget.org:443, which only accepts TLS 1.2+:SslProtocols.Tls(old default): connection reset by peer🤖 Generated with Claude Code