Repository navigation
Release 1.4.0: restore netstandard2.0, add trusted-publishing NuGet workflow - #53
Merged
Merged
Conversation
Target netstandard2.0 alongside net10.0 so the package still installs on .NET Framework and .NET below 10, and move the package metadata from the nuspec into the csproj (Apache-2.0 license expression, repository links, README, release notes). The old nuspec packed a Debug build. Add build-and-publish.yml: builds, tests and packs on pushes and PRs to master; on a v* tag it checks the tag matches the package version and pushes to nuget.org through trusted publishing (OIDC), so no API key is stored in the repository. 1.4.0 also ships the fix for #46 (TcpTransport.Read spinning at 100% CPU when the server closes the connection). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
checkout v7, setup-dotnet v6, upload-artifact v7, download-artifact v8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
netstandard2.0;net10.0. The net10 migration had droppednetstandard2.0, which would have made the next release uninstallable on .NET Framework and on .NET below 10.EppLib.nuspec(deleted; it packed a Debug build) intoEppLib.csproj, with an Apache-2.0 license expression, CodeMakerInc repo links, README and release notes. Version is 1.4.0.build-and-publish.yml:v*tag, it checks the tag matches the csproj version, then pushes to nuget.org via trusted publishing (NuGet/login@v1, userademar, no environment). No API key is stored.Testing
dotnet packoutput haslib/netstandard2.0andlib/net10.0.TestDomainsSuspendedNotificationfails outside UTC because the test asserts local time. It passes on CI, which runs in UTC.Releasing
Tag
v1.4.0has been created locally on this branch's commit but not pushed. Merge with a merge commit (not squash) so the tag stays on master, thengit push origin v1.4.0to publish.🤖 Generated with Claude Code