Repository navigation
Complete Identity service replacement and fix Flyway configuration - #36
Merged
Merged
Conversation
### I DECIDED TO ADD MULTI-LAYER AUTHENTICATION BECAUSE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
The local OTP-retirement commit deleted
payguard-otp-service, but its committed parent POM still selected that module and required Identity application files remained untracked. The pre-push hook validates a clean committed worktree, so Maven failed before it could run quality checks. This PR completes the existing Identity replacement and keeps the separately implemented Flyway configuration fix in its own commit.It completes the source integration following PostgreSQL/Vault PR #35; it does not implement new authentication workflows.
Changes
value(), CustomerId'sgetValue(), case-sensitive prefixed identifiers and UUID audit IDs.FLYWAY_URL,FLYWAY_USER,FLYWAY_PASSWORDandFLYWAY_INIT_SQLduring Maven plugin execution. Remove unresolved POM property references and reject omitted owner initialization. The supported Vault-managed migration helper keeps its own workflow.Five unused future ID classes, CLAUDE.md, an unrelated ADR rename and protected local artifacts remain outside this publication. No quality rule or repository protection was disabled.
Validation
fd29d35: full Mavenverifypassed, 91 tests, zero failures/errors/skips. Spotless, Checkstyle, PMD, CPD and SpotBugs passed. Identity's 14 real PostgreSQL infrastructure cases and 11 application contracts passed.b230d03: Spotless, Checkstyle, install, PMD, SpotBugs and full verification, 91 tests with zero failures/errors/skips. No hook bypass or force push.loan_owner; omitted owner initialization was rejected. Only the newly created test containers/volumes were removed.GitHub quality, database-security, image-build and CodeQL results must be assessed on this PR. Local checks do not substitute for CodeQL's required GitHub analysis.
See the repair log and the migration guide. Live Oracle cutover, new authentication/enrollment, missing financial adapters and durable external delivery remain separate work.