Repository navigation
chore: support Ubuntu 26.04 - #574
Conversation
Merging this PR will degrade performance by 70.23%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | memtrack track dd |
1.2 s | 1.1 s | +11.72% |
| 👁 | Memory | sleep 1 |
15.6 KB | 103.4 KB | -84.92% |
| 👁 |
Simulation | sleep 1 |
245.4 µs | 1,566.4 µs | -84.33% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing cod-3305-support-ubuntu-2604 (4f33c00) with main (5ff86d7)
Footnotes
-
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
694b5ce to
3230d82
Compare
761a30d to
2bff3c6
Compare
|
2bff3c6 to
d887e80
Compare
d887e80 to
5734419
Compare
The executor tests always ran in an Ubuntu 24.04 container. The Dockerfile now takes a BASE_IMAGE build argument, set from CODSPEED_TEST_BASE_IMAGE (default ubuntu:24.04), so the suite can run on other releases such as Ubuntu 26.04. Each base image gets its own image tags, setup container and target volume: binaries built against a newer glibc do not run on an older one, and the setup image cleanup no longer deletes another base's image. `just clean-integ` removes them all by name filter. CODSPEED_VALGRIND_BUILD_FROM_SOURCE is forwarded to the containers when set, so the valgrind source-build fallback can be controlled in the tests. Refs COD-3305 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5734419 to
64e1085
Compare
Ubuntu 20.04 and Debian 11 have no patched valgrind package and are rejected by the runner, so drop them from the supported list. Refs COD-3305 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run the CI on Ubuntu 26.04 alongside 24.04: the unit tests and the basic run test on
ubuntu-24.04andubuntu-26.04runners, and the executor tests onubuntu:24.04andubuntu:26.04base images.The executor tests run in Docker, so the Dockerfile now takes a
BASE_IMAGEbuild argument, set bytests/docker/run.shfromCODSPEED_TEST_BASE_IMAGE(defaultubuntu:24.04). Each base image gets its own image tags, setup container and target volume: binaries built against 26.04's glibc do not run in a 24.04 container, and the setup image cleanup would otherwise delete the other base's image.The workflow sets
CODSPEED_VALGRIND_BUILD_FROM_SOURCE=false(forwarded into the test containers), so a system we publish no valgrind package for fails instead of falling back to a source build that takes minutes and hides the missing package. No valgrind-codspeed package is published for 26.04 yet, so the simulation runs on 26.04 are expected to fail until it is: the 14 simulation executor tests and the wholebasic-run-test (ubuntu-26.04)job. Note thatcodspeed setuponly warns when valgrind cannot be installed, so the failure surfaces atcodspeed run, not at setup.With the fallback left on, the full executor suite passes locally on
ubuntu:26.04(valgrind-codspeed built from source, every shard green).Refs COD-3305, which stays open until valgrind-codspeed is published for 26.04.