Skip to content

CI: Swift 6.4 on every lane (Xcode 27.1, swift:6.4.2, setup-swift 6.4.2, Android 6.4.2) - #29

Merged
odrobnik merged 2 commits into
mainfrom
agent/issue-28
Nov 2, 2026
Merged

odrobnik merged 2 commits into
mainfrom
agent/issue-28

Conversation

@odrobnik

@odrobnik odrobnik commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Closes #28.

Every CI lane now builds with Swift 6.4, matching Cocoanetics/SwiftText:

  • macOS and iOS: xcode-27 image with Xcode 27.1. The iOS platform is downloaded with retries, since this image ships without it.
  • Linux: swift:6.4.2.
  • Windows: setup-swift 6.4.2.
  • Android: Swift 6.4.2 on ubuntu-latest.

Every lane runs a "Verify Swift version" step. The Swift 6.2 libswiftCompatibilitySpan back-deployment workaround is removed, because Swift 6.4 no longer needs it.

The MissionControl implementor ran it locally: build, lint and 67 tests pass. The supervisor pushed the branch, because MissionControl's token can't push workflow files yet.

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T10:09:46.800980Z 097ee4b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 097ee4bb95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/swift.yml Resolved
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@odrobnik

odrobnik commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Agent summary

MissionControl verification: passed

  • swiftlint: passed
  • swift build --build-tests: passed
  • swift test --skip-build: passed
  • Xcode app build: skipped — no project.yml
  • Xcode mobile app build: skipped — no project.yml

Agent report:

I added ndk-version: latest to the build-android job in .github/workflows/swift.yml. That addresses the Codex review finding. The Swift 6.4 Android SDK needs NDK 30, and the runner's default NDK is still 27.x. With latest, the action selects the NDK 30 install.

  • Verification: I haven't run the Android job, and I didn't run swift build or swift test. The change is workflow-only. Lint passed, and the five checks on the previous head were already green.
  • Push: I made no commit and didn't push. MissionControl handles that, and its token may be unable to push workflow files. If the push fails, the supervisor pushes the branch.
  • Review thread: I replied to the Codex thread (rc4441108184), marked the reviewer correct, and resolved it.

@odrobnik odrobnik left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up review of 668e4c6. The earlier Android finding is addressed: ndk-version: latest is now set on the Android job, and the change is workflow-only. Every lane builds with Swift 6.4 and has a "Verify Swift version" step. The ubuntu-24.04 pin and the Swift 6.2 compatibility-library workaround are gone. No Markdown file in the repo states a toolchain version, so there is no doc to update. All five CI lanes are green on this head, including the Android lane, whose verify step ran after the action. I found nothing to raise. I only read the diff and docs and did not run builds or tests.

👍 No findings.

Reviewed by Claude

@odrobnik
odrobnik merged commit 932f38a into main Nov 2, 2026
5 checks passed
@odrobnik
odrobnik deleted the agent/issue-28 branch November 2, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Swift 6.4 on every lane (Xcode 27.1, swift:6.4.2, setup-swift 6.4.2, Android 6.4.2)

1 participant