Repository navigation
Conversation
ServerInfo had no default member initializers, and Client::Impl::ReceiveHello reads timezone, display_name and version_patch only when the server revision carries them. A server below revision 54401 left version_patch indeterminate, and reconnecting to an older server kept the previous server's values. Default-initialize the numeric members and reset server_info_ before parsing each Hello.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerInfoinclient.hhas no default member initializers, andClient::Impl::ReceiveHelloreadstimezone,display_nameandversion_patchonly when the server's revision carries them. A server below revision 54401 leavesversion_patchindeterminate, soGetServerInfo()returns stale heap bytes. Reconnecting to an older server also keeps the previous server's values.Fix: default-initialize the numeric members, and reset
server_info_before parsing each Hello.Reproducer: a Hello packet that announces revision 54400 (or anything below 54401), after a connection to a newer server.
Tests:
ClientProtocol.ReconnectToOldRevisionServerClearsPreviousServerInfofails on master: it keeps"UTC","d"and7.ClientProtocol.OldRevisionServerHelloLeavesMissingFieldsZerois a control. It can pass on master when the fresh heap happens to be zero.