Skip to content

fix(web): accept local-chatgpt provisional conversation URLs - #226

Merged
ChesterRa merged 1 commit into
ChesterRa:mainfrom
chriscoveries:fix/chatgpt-provisional-conversation-id
Nov 16, 2026
Merged

ChesterRa merged 1 commit into
ChesterRa:mainfrom
chriscoveries:fix/chatgpt-provisional-conversation-id

Conversation

@chriscoveries

Copy link
Copy Markdown
Contributor

Fixes new-chat pairing failing when ChatGPT assigns a local-chatgpt provisional URL.

ChatGPT can move the tab from / to https://chatgpt.com/c/local-chatgpt%3A<uuid> before it assigns the stable conversation ID. The pairing check only recognized the WEB: and WEB%3A provisional prefixes, so it treated that URL as a changed target and returned pairing_target_changed.

This also accepts local-chatgpt: and local-chatgpt%3A as provisional. The handshake remains pending until ChatGPT reaches a real /c/<uuid> URL, and no provisional URL can be bound.

Added one test using the exact provisional URL shape, alongside the existing provisional-route cases.

ChatGPT can move a new-chat pairing from / to /c/local-chatgpt:<id> before assigning the stable conversation id. Treat that prefix as provisional so the handshake waits instead of failing with pairing_target_changed.
@ChesterRa
ChesterRa merged commit 653d15f into ChesterRa:main Nov 16, 2026
7 checks passed
ChesterRa added a commit that referenced this pull request Nov 16, 2026
MCP recipes: `capability_import` accepted `command` as a string or argv
array, and a package recipe's fallback command without an identifier,
but installation used only the two candidate lists, so such records
imported and then failed to install. Import validation, installation and
the recipe fingerprint now share one parser. A string names one
executable and is never split by a shell; arguments need an argv array,
kept as written. Candidates are tried as `command_candidates`,
`command`, `fallback_command_candidates`, `fallback_command`; a package
recipe uses its registry only with a supported registry and a non-empty
identifier. Malformed command fields are rejected before the catalog
changes, and a string that looks like a whole command line gets a hint
to use an argv array. The fingerprint of an existing command recipe
containing only argv-array candidates is unchanged. Previously ignored
`command`, `fallback_command` or string candidates now affect the
fingerprint, so an old installation may report a changed recipe until
explicitly updated; its installed invoker is not replaced automatically.

Automation: a cron rule that already owes a run, for example one enabled
again after missing its time, reported the following occurrence as its next
fire, although the owed run could fire on the next eligible tick. It now
reports the run it owes, as interval and one-time rules already did; the Web
compares that with the daemon's `server_now` and labels the time as pending.
The run still fires once, on the first tick that can carry it out.

Capability page: the Enabled card counted only the page on screen, while the
Skills, MCP and Packs cards counted the whole search. `capability_overview`
now returns `enabled_count` over the same matches as `kind_counts`, after
seeding the Group's default capabilities as a state read does, and the Web
uses it.

Documentation: the home page's getting-started button links to the page's
own address, so opening it directly no longer returns 404. The operations
guide gains a table of what a daemon restart keeps, with a FAQ entry. The
daemon IPC standard documents the command forms, `kind_counts`,
`enabled_count` and the due `next_fire_at`.

ChatGPT: with #227 a delivery receipt also matches on the other route form
of the same conversation. Recovering an uncertain delivery from such a
receipt recorded the Project address as the conversation that received the
session bootstrap, so the next delivery sent the bootstrap into the same
chat again; it now records the bound conversation. The changes merged from
#226 and #227 gain regressions: both provisional URL forms stay pending
through pairing, and a conversation moved into a Project keeps its
exact-batch receipt without navigating or sending again, while another
conversation's receipt is rejected.

Validation: both maintainers reviewed the whole batch independently, and a
fresh-context review traced the four user paths across entry points before
the gate. The bootstrap-record and due-run wording findings are fixed here.
On the final tree: `npm run check`, `npm run build` and `npm test` (668
files, 5019 tests); the repository pytest (126); `git diff --check`;
`cargo fmt --all -- --check`;
`cargo clippy --workspace --all-targets --locked -- -D warnings`;
cargo-nextest's `ci` profile with real Chrome forbidden (4031 passed), its
`chrome` profile (47 passed) and the `daemon_self_launch` tests run serially
(3 passed), so each of the 4081 non-ignored tests among the 4091 listed ran
exactly once across the three gate groups. Four selected regressions also
ran before the full gate.
@ChesterRa

Copy link
Copy Markdown
Owner

Thanks for the focused fix. It is merged into main in 653d15f. Follow-up coverage checks both the plain and percent-encoded local-chatgpt: forms: pairing stays pending while a new chat still has a provisional ID, and neither form can become a bound conversation. Those pairing regressions passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants