Repository navigation
A UI can be audited, commented on, and built only once approved - #31
Merged
Merged
Conversation
Add vstack:design-review. It audits the current work at a chosen polish level, opens its proposals in vstack:review for comments, and builds what the owner approves. It runs vstack:proofread on new UI copy only. Fix the stream watcher so an approval is announced. Approve closes the server within one poll, and the watcher checked for a closed server first, so it usually reported "the tab went away" and never APPROVED. The build step depends on that event. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds
vstack:design-review, released as 6.10.0. It is a MINOR bump because it is a new skill.vstack:reviewfor comments. Product code stays unchanged until Approve & finish or the owner says to build. It then builds one slice at a time. Later rounds mark each earlier area as Landed, Landed but broken, or Moved.design-reviewis for an audit with proposals.reviewis for commenting with no audit. Each description now names the other.design-reviewcounts as the requestproofreadneeds, for new UI copy only. If proofread stops, nothing is sent and the build continues. The description, README and changelog all say that UI copy goes to ChatGPT.browser_captureis not available.CLOSED … the tab went awaywith noAPPROVED. The build step depends on that event. The first drive of this skill hit the bug.How it was tested
Host: Claude Code. An agent followed the skill files from this branch by hand in a scratch project, with the demo todo app as the target:
APPROVEDand thenCLOSED.Also run:
review-lifecycle.mjshas a new regression test, which failed before the fix.cucumber-jsunder both hosts: 45 of 45 scenarios pass on each.claude plugin validate --stricton both manifests.plugin detailslists 5 skills, includingdesign-review.Not exercised:
browser_capturethrough Claude in Chrome. Playwright did the capture./vstack:design-review, or a human reviewer.gitleakslocally. CI runs it.Checklist
.vstack/local/<tool>/. The skill names.vstack/local/design-review/in its instructions and has no engine code.lib/shell/: not applicable.plugins/, and raisedversionin both host manifests with a matchingCHANGELOG.mdentry. Merging this publishes it.🤖 Generated with Claude Code