Skip to content

The canvas stays where the reviewer was when the page changes height - #30

Merged
DeyangChan merged 1 commit into
mainfrom
fix/canvas-keeps-scroll
Nov 6, 2026
Merged

DeyangChan merged 1 commit into
mainfrom
fix/canvas-keeps-scroll

Conversation

@DeyangChan

Copy link
Copy Markdown
Member

What this changes

Fixes the canvas jumping to the top of a long page. If a reviewer had scrolled down and the page then changed height, fitFrameHeight shrank the frame, which clamped the canvas scroll to 0.

  • The scroll is now read before the frame shrinks and restored afterwards. The modal path in the same function already does this.
  • New scenario F4 in e2e/features/framing.feature covers it.

The version goes to 6.9.1, because this is a fix.

How it was tested

  • F4 failed without the fix: the canvas was at 1500 and is now at 0. It passes with the fix.
  • The full Gherkin suite passes under both hosts: 45 scenarios under Claude and 45 under Codex.
  • The six review test suites, the proofread tests, the shell check, and both manifest validations pass locally.

This drives the shipped workspace in headless Chromium through the e2e suite, with a mock agent in the agent's seat. It was not run through a live agent session.

Checklist

  • Nothing writes outside the user's project, and nothing transmits anywhere.
  • Pages stay self-contained. No external requests at runtime.
  • Changed something under plugins/, and raised version in both host manifests with a matching CHANGELOG.md entry. Merging this publishes it.
  • The security scans that run locally pass, and no finding was silenced.
  • Installed the plugin from this branch and drove the affected skill end to end. The e2e suite covers the workspace, but no live agent session was run.

🤖 Generated with Claude Code

Refitting the frame shrinks it first, which clamps the canvas scroll to 0. The
scroll is now read before the frame shrinks and restored afterwards, as the
modal path already did. A new end-to-end scenario fails without this.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DeyangChan
DeyangChan merged commit 562879d into main Nov 6, 2026
13 checks passed
@DeyangChan
DeyangChan deleted the fix/canvas-keeps-scroll branch November 6, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant