Repository navigation
The canvas stays where the reviewer was when the page changes height - #30
Merged
Merged
Conversation
Refitting the frame shrinks it first, which clamps the canvas scroll to 0. The scroll is now read before the frame shrinks and restored afterwards, as the modal path already did. A new end-to-end scenario fails without this. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes the canvas jumping to the top of a long page. If a reviewer had scrolled down and the page then changed height,
fitFrameHeightshrank the frame, which clamped the canvas scroll to 0.e2e/features/framing.featurecovers it.The version goes to 6.9.1, because this is a fix.
How it was tested
the canvas was at 1500 and is now at 0. It passes with the fix.This drives the shipped workspace in headless Chromium through the e2e suite, with a mock agent in the agent's seat. It was not run through a live agent session.
Checklist
plugins/, and raisedversionin both host manifests with a matchingCHANGELOG.mdentry. Merging this publishes it.🤖 Generated with Claude Code