Skip to content

docs: encode the WizardConnect sign request before sending it over th… #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AhmadReza6610 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: encode the WizardConnect sign request before sending it over th… #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion website/docs/guides/walletconnect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,10 @@ WizardConnect covers transaction signing only. For arbitrary message signing, us

Send the request to your WizardConnect dapp client. Its `signTransaction` method takes the `transaction` and `inputPaths` and returns the signed transaction.

WizardConnect sends requests over its relay as plain JSON, which cannot hold the `bigint` and `Uint8Array` fields of the `WcTransactionObject`. Passing the object as-is throws `TypeError: Do not know how to serialize a BigInt`. Encode the transaction object with libauth's `stringify` first, as with BCH WalletConnect.

```ts
import { stringify } from "@bitauth/libauth";
import { type WcTransactionObject } from "cashscript";

interface SignTransactionRequest {
Expand All @@ -280,7 +283,10 @@ async function signWizardTransaction(
request: SignTransactionRequest,
): Promise<string | undefined> {
try {
const result = await dappConnectionManager.signTransaction(request);
const result = await dappConnectionManager.signTransaction({
transaction: JSON.parse(stringify(request.transaction)),
inputPaths: request.inputPaths,
});
return result.signedTransaction;
} catch (error) {
return undefined;
Expand Down
Loading