Repository navigation
fix(desktop-gpui): keep the main window hidden after an Instant recording - #3440
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping an Instant recording on macOS opened the share link in the browser and then brought Cap's main window back on top of it, so it had to be closed by hand. The main window now stays hidden after a clean Instant recording unless the user picks the new Show Cap outcome.
flowchart TD A[Instant recording stops cleanly] --> B{After an Instant recording} B -->|Open link| C[Link copied + opened in browser<br/>main window stays hidden] B -->|Show Cap| D[Link copied<br/>main window comes back] B -->|Copy link only| E[Link copied<br/>nothing opens]apps/desktop-gpui/src/session.rs:1386setsfinished_instantwhen an Instant recording stops cleanly. Low storage still counts as unclean, so its notice is still shown in the main window.apps/desktop-gpui/src/app_windows.rs:667reads it alongsidefinished_studio. Unless the outcome is Show Cap, it takes the same path as Studio's "Do nothing": it parks the camera preview, syncs the dock and leaves the main window hidden. Failures, errors and recordings without a link still bring it back.Setting
Settings > Shortcuts > After an Instant recording:
disableAutoOpenLinksis shared with the Tauri app, so the third state lives in a new key,showMainWindowAfterInstantRecording, and the two keys together make upstore::PostInstantBehaviour:showMainWindowAfterInstantRecordingas equal todisableAutoOpenLinks. Anyone on "Copy link only" saw the main window come back, so they now load as Show Cap and nothing changes for them.real_app_instant_outcome_decides_whether_main_window_returnsrecords an Instant clip againstMockCapunder each outcome. It checks that the observer keeps the main window hidden for Open link and Copy link only, and takes the reshow for Show Cap.

Confidence Score: 5/5
The PR appears safe to merge, with no outstanding actionable findings.Summary
The PR keeps Cap hidden after a clean Instant recording unless the user selects Show Cap.
The three earlier threads are addressed. No new actionable issues were found. This review checked code paths; it did not run the native app or integration tests.
Reviews (4) · Last reviewed commit: "test(desktop-gpui): require the Show Cap..." · Reviewed by Greptile