Repository navigation
test(editor): fuzz Studio Sound export windows over random cuts - #3435
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@greptileai review |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a randomized regression test for the "Invalid sequential export audio window" export failure with Studio Sound on.
In 0.6.1, a Studio Sound export of a timeline with a short cut inside one clip failed with that error every time. Turning Studio Sound off made it export. Main already fixes this (594e1b6 and c62021c), but the existing tests only cover a few hand-picked timelines.
Test
studio_sound_random_cuts_never_reject_the_export_windowbuilds random eligible timelines and exports them through the streaming path with Studio Sound on. Each run varies:It uses voice-like test audio with loud and quiet stretches, so the leveler and denoiser do real work. It fails if any export returns an error or writes a different number of samples than the preview renderer. By default it runs 12 iterations, about 50 s in a debug build.
CAP_AUDIO_FUZZ_ITERATIONSandCAP_AUDIO_FUZZ_SEEDwiden the search locally.Verification
STUDIO_SOUND_HISTORY_SAMPLESto 0 recreates the 0.6.1 behaviour (reads only move forward). With that change every iteration fails with "Invalid sequential export audio window", so the test catches the original bug.export_audiotests pass.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Adds a repeatable randomized test for Studio Sound exports across cuts.
Reviews (1) · Last reviewed commit: "test(editor): fuzz Studio Sound export w..." · Reviewed by Greptile