Repository navigation
fix(chrome-extension): keep the dev-server hint to local Cap URLs - #3418
Open
patrickballard wants to merge 1 commit into
Open
patrickballard wants to merge 1 commit into
patrickballard wants to merge 1 commit into
Conversation
A sign-in that couldn't reach the auth route told every user to start the local web server with bun run dev:extension. Keep that hint for a local Cap URL, and otherwise ask the user to check their connection and the Cap URL, with the underlying error.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3417.
When the auth route can't be reached, the popup now says:
The existing dev-server message stays when the Cap URL is
localhost,127.0.0.1or[::1], where it's the right advice.Tests
src/shared/api.test.ts: a production and a self-hosted URL get the new message with the underlying error; a local URL keeps the dev-server hint. The first case fails without the change.bun run --cwd apps/chrome-extension test: 41 passed.typecheckclean. Biome clean.
This PR appears safe to merge.Summary
The extension now gives connection advice when sign-in fails for a remote Cap URL.
Reviews (1) · Last reviewed commit: "fix(chrome-extension): keep the dev-serv..." · Reviewed by Greptile