Repository navigation
fix(rendering): ignore cursor movement in timeline cuts for auto zoom - #3338
Merged
richiemcilroy merged 6 commits intoOct 26, 2026
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Member
|
@greptileai review |
Member
|
@greptileai review |
richiemcilroy
approved these changes
Oct 26, 2026
richiemcilroy
left a comment
richiemcilroy
left a comment
Member
There was a problem hiding this comment.
Verified for 0.6.2: Greptile 5/5 on this head, full CI green, and the full test suites pass on macOS with this PR combined with the other 0.6.2 changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when an auto zoom segment spans a cut on the timeline, the camera was aiming using cursor movement from the part that got cut out. the zoom maps its start and end back to recording time and takes every move in between, so a cut in the middle pulled the focus toward stuff the viewer never sees.
now if the zoom crosses a cut, it only uses cursor moves from the recording ranges that are actually kept, plus wherever the cursor was sitting when each kept part starts. a zoom ending exactly on a cut counts too. zooms without a cut skip this entirely and render bit-identical to before, which the new tests check across splits, speed changes and text holds.
The PR appears safe to merge, with no outstanding findings.Summary
Auto zoom now ignores cursor movement in deleted timeline ranges while preserving the cursor position carried into each kept range.
Reviews (6) · Last reviewed commit: "chore(rendering): drop narrating doc com..." · Reviewed by Greptile