Skip to content

fix(presets): keep caption text in the editor and CLI - #3311

Merged
richiemcilroy merged 4 commits into
CapSoftware:mainfrom
AksharP5:preset-caption-source
Oct 26, 2026
Merged

richiemcilroy merged 4 commits into
CapSoftware:mainfrom
AksharP5:preset-caption-source

Conversation

@AksharP5

@AksharP5 AksharP5 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Applying a preset in the GPUI editor or a CLI upload automation could replace a recording's caption text with another recording's transcript, or clear its saved caption source. CLI automations also discarded the current clip offsets.

Both paths now share the project merge: keep the recording's caption source, timing, timeline, clips and text versions while applying preset styling. Built-in Default uses it too. Newly saved presets contain caption settings without transcript text. CLI application uses defaults for a missing config and surfaces other load errors before writing.

Closes #3310.

Same operation Before After
Apply a preset containing Other recording to Current recording Track reads Other recording Track reads Current recording; preset styling applies
Apply an uncaptioned preset or built-in Default Saved caption source removed Caption text and timings remain; default settings apply
Upload an existing captioned project with an Apply preset automation Caption source replaced or emptied; clip offsets discarded Current caption source, cuts, overrides and clip offsets retained
Save a captioned project as a preset Transcript text is stored in the preset Only caption settings are stored

Verification on df1e9e2ae5dbb7f05da3e8f37a879a879fa2f5e3: 13 production GUI preset tests, 3 CLI regressions and 195 shared-project tests pass; four benchmarks are ignored. The original GUI reproductions fail before the fix. Against the original CLI method, caption preservation and unreadable-config protection also fail.

An independent GPT-6.1 Sol xhigh review passed the full patch, 25 focused tests including nine additional probes, and the 195 project tests. The old CLI method fails six of those nine probes. Tests cover actual project IO, caption synchronization and save/reopen, legacy timing across cuts, per-caption overrides, text versions, missing configs, and load/write failures.

Formatting, whitespace and scoped strict Clippy pass. Verification uses actual GUI/project sources and verbatim CLI methods with store/context fixtures. Full local workspace/native checks stop at missing pkg-config/OpenSSL dependencies; dependency-inclusive Clippy also encounters existing Rust 1.99 warnings. No native GUI or live upload was run. Greptile reviewed df1e9e2 at 5/5.

Native CI on df1e9e2 passed the full GPUI app tests on Apple Silicon macOS, Windows, and Linux: 1,477, 1,436 and 1,552 tests passed respectively, with zero failures and all 13 preset tests included. macOS/Windows Clippy and Linux Rust tests also passed. Those native results cover df1e9e2.

After the maintainer merged upstream main in 7419e76, the four-file fix has the same stable patch ID as the independently reviewed version. All 13 GUI preset tests, 3 CLI regressions and 196 shared-project tests pass against the merged source, with four benchmarks ignored; formatting and whitespace checks pass. Native CI and Greptile are rerunning for the merge commit.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

The editor and CLI now use with_preset to apply styling without replacing recording-specific captions or edits.

  • Presets change a recording's look without replacing its captions or edits.
  • Saved presets keep caption settings without transcript text.

No actionable issues were found. This review checked source paths; it did not run tests or the native UI.

Reviews (4) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@AksharP5

Copy link
Copy Markdown
Contributor Author

@greptileai review

@AksharP5 AksharP5 changed the title fix(desktop-gpui): keep caption text when applying presets fix(presets): keep caption text in the editor and CLI Oct 26, 2026
@AksharP5

Copy link
Copy Markdown
Contributor Author

@greptileai review

@richiemcilroy

Copy link
Copy Markdown
Member

@greptileai review

@richiemcilroy richiemcilroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified for 0.6.2: Greptile 5/5 on this head, full CI green, and the full test suites pass on macOS with this PR combined with the other 0.6.2 changes.

@richiemcilroy
richiemcilroy merged commit 1d0c782 into CapSoftware:main Oct 26, 2026
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applying a native editor preset replaces or clears the current caption text

2 participants