Skip to content

fix(desktop-gpui): import desktop wallpaper on windows - #2786

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
dovidmoishe:fix/windows-desktop-background-import
Oct 22, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
dovidmoishe:fix/windows-desktop-background-import

Conversation

@dovidmoishe

@dovidmoishe dovidmoishe commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

The GPUI editor’s “Import desktop background” button previously failed on Windows because wallpaper lookup returned no path.

  • Read the current wallpaper path through the Windows API.
  • Detect image formats from file contents, including extensionless files.
  • Restrict the sips converter to macOS.
  • Show an alert when importing fails.

Validation:

  • Windows import manually confirmed working.
  • Rust formatting and whitespace checks passed.
  • Independent review found no actionable bugs.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Fixes desktop wallpaper import on Windows.

  • The editor can import the current desktop wallpaper on Windows.

No actionable issues were found. Review was based on source inspection; no build or runtime checks were run.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): import desktop wallpa..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@dovidmoishe is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy

Copy link
Copy Markdown
Member

Thanks @dovidmoishe! We've reviewed this and it looks good to merge. Our automated reviewer (Greptile) is temporarily not posting reviews; as soon as it scores this 5/5 and CI is green on the branch updated with main, we'll merge it.

@dovidmoishe

Copy link
Copy Markdown
Contributor Author

Awesome! Looking forward to it, @richiemcilroy!

Also, keep an eye on #2703. I've pushed a new commit and updated my comment to address your review feedback.

#2605 is also at 5/5 on Greptile!

@dovidmoishe

Copy link
Copy Markdown
Contributor Author

@greptileai

@richiemcilroy

Copy link
Copy Markdown
Member

@greptileai review

@richiemcilroy
richiemcilroy merged commit 2a1baae into CapSoftware:main Oct 22, 2026
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants