Repository navigation
chore(deps): bump @sveltejs/kit to 2.70.4, SvelteKit's 2.x security release - #229
Merged
Merged
Conversation
Lockfile only. The ^2.70.2 range already allows it, and 2.70.4 has the same dependencies and peer dependencies as 2.70.3, so no other package moves; only the Kit entry and the snapshot keys that embed its version change. 2.70.4 is SvelteKit's 2.x security release. Its advisories list it as patched for GHSA-27mw-82g8-phjj (cache-control escaping in prerendered HTML), GHSA-prjg-x2qj-wj3g, GHSA-rqp5-r3wg-vg35, GHSA-mw6w-2fmv-pvw3 and GHSA-xgrj-p7pg-6vm3. None affects the built app: adapter-static, no prerendered pages, no setHeaders, no server routes or hooks, and client-side route resolution (GHSA-xgrj is vite preview on Windows). GHSA-pfhg-q3qv-9q6r (use:enhance) is fixed only in 3.0.0 and does not affect it either: there are no form actions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
@sveltejs/kit2.70.3 → 2.70.4 — lockfile-only bump infrontend/pnpm-lock.yaml; the five snapshot keys that embed the Kit version (adapter-static,bits-ui,runed,svelte-toolbelt) move with it and nothing else resolves differently.- Verified against the registry — the new
sha512-IDfRnmSX…B+rg==integrity matches 2.70.4'sdist.integrity, and 2.70.4 declares the same dependencies, peer dependencies, engines andbinas 2.70.3, so the unchanged snapshot dependency block is correct rather than an omission. - Override still applies — Kit continues to request
cookie@^0.6.0, so thepnpm.overridesremap to^0.7.2infrontend/package.jsonstill catches it; the snapshot still resolvescookie: 0.7.2. - No leftover references — zero occurrences of
2.70.3remain in the lockfile. - CI green on
6091935— thecheckjob ranpnpm install --frozen-lockfile,pnpm check,pnpm buildandpnpm test:visualsuccessfully, which is the real validation for a lockfile-only change.
The "does it affect this app?" reasoning in the description holds on the tree: adapter-static with fallback: '200.html', ssr = false / prerender = false, and no setHeaders, use:enhance, $app/forms, reroute or router.resolution usage under frontend/src/. The one advisory this cannot close (GHSA-pfhg-q3qv-9q6r, needs 3.0.0) has no reachable surface here since there are no form actions or use:enhance calls, and the description already calls that out. Rebase coordination with #228 is documented too.
deepseek-v4.1-flash | 𝕏
shockalotti
added a commit
that referenced
this pull request
Nov 10, 2026
Supersedes the lockfile part of #228, whose branch could not be rebased from here (push to that fork is denied) and which conflicted with #229 on this same file. Resolved with `pnpm update --lockfile-only --no-save`, so **only pnpm-lock.yaml changes**. No range and no source file is touched: the new versions all satisfy the ranges package.json already declared, and `pnpm install --frozen-lockfile` accepts the result. Before: 20 advisories - 6 high, 9 moderate, 5 low. After: 3 advisories - 0 high, 0 moderate, 3 low (@sveltejs/kit x2, deepmerge). The highs were real and one is runtime: `devalue` ships in the SvelteKit client bundle. The others were `source-map-js`, `vite` and `@vitest/mocker`. Versions that moved, all inside the declared ranges: vite 8.3.0 -> 8.3.7 vitest 4.1.11 -> 4.1.12 bits-ui 2.19.5 -> 2.20.6 cropperjs 1.6.2 -> 1.7.0 tailwindcss 4.3.3 -> 4.3.5 devalue 5.8.1 -> 5.9.4 source-map-js 1.2.1 -> 1.2.2 Validated locally with the original package.json in place: `pnpm install --frozen-lockfile`, `pnpm check` (0 errors, 0 warnings), `pnpm test:visual` (27/27) and `pnpm build`. The visual suite is why the bits-ui and cropperjs bumps are acceptable rather than assumed safe. Deliberately NOT done here: raising the declared ranges. `pnpm update` does that by default, which would turn a security re-resolve into a dependency upgrade; that decision deserves its own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Lockfile only:
@sveltejs/kit2.70.3 to 2.70.4 infrontend/pnpm-lock.yaml. The^2.70.2range already allows it, and 2.70.4 declares the same dependencies and peer dependencies as 2.70.3, so no other package moves and thecookie@^0.6.0override still applies.Why
2.70.4 is SvelteKit's security release for the 2.x line. Each of the five fixes in its release notes has a SvelteKit advisory that lists 2.70.4 under its patched versions (the text of three of them still says to upgrade to 3.0.0):
cache-controlvalue set withsetHeaderson a prerendered pageprerender = false, and nothing callssetHeadersadapter-static; Go serves the built files)//pathnames under server-side route resolutionreroutehook that rewrites a malformed pathname crashesadapter-nodereroutehook and noadapter-nodevite previewon Windowspnpm previewon Windows; the dev server and the built app are not affectedSo this is housekeeping rather than a fix for a live problem. It also keeps the tree on Kit 2, since Kit 3 is a migration of its own here: Svelte config moves from
svelte.config.jsinto thesveltekit()Vite plugin,$libbecomes#lib, TypeScript 6 is the minimum, andadapter-staticneeds v4.What scanners will still report
pnpm auditand OSV (and so Dependabot and Scorecard) will still list two Kit advisories after this merges:escape_htmlchange 3.0.0 made), and SvelteKit's advisory lists>= 2.70.4as patched, but the GitHub Advisory Database record still says< 3.0.0. Scanners will keep reporting it until that record is updated to include 2.70.4.use:enhanceon//paths). This one is not fixed here: it needs 3.0.0, and SvelteKit lists only 3.0.0 as patched. It does not affect this app, which has no form actions and nouse:enhance.The other four are not in the GitHub Advisory Database or OSV yet, so scanners do not report them against 2.70.3 today; SvelteKit's advisories for them already list 2.70.4 as patched.
Lockfile
Only the Kit entry and the snapshot keys that embed its version change (
adapter-static,bits-ui,runed,svelte-toolbelt).pnpm up @sveltejs/kitwould also refreshgraphqlandset-cookie-parserinmsw's tree; they are left out to keep this to Kit.#228, a separate lockfile-only PR, bumps
vite,vitest,devalueandsource-map-jsfor 17 other advisories. It touches the same snapshot keys (they embed theviteversion), so whichever of the two merges second needs a rebase. I will rebase it.How it was checked
packageManagerpin) infrontend/:pnpm install --frozen-lockfile --lockfile-onlypasses, and a freshpnpm install --lockfile-onlyrewrites nothing.integritymatches the registry'sdist.integrityfor 2.70.4, and the registry metadata for 2.70.4 has the same dependencies, peer dependencies, engines andbinas 2.70.3.pnpm auditandosv-scannerv2.7.0 report 20 advisories before and 20 after. Both list GHSA-27mw-82g8-phjj and GHSA-pfhg-q3qv-9q6r against 2.70.4, as described above.adapter-staticwithfallback: '200.html'; the root+layout.tssetsssr = falseandprerender = false; there is nosetHeaders,use:enhance,$app/forms,reroute,router.resolutionsetting, server route, server load or hooks file.pnpm install --frozen-lockfile,pnpm check,pnpm buildandpnpm test:visualon it.🤖 Generated with Claude Code