Repository navigation
fix(ui): label and guard the "your own system" invite mode - #192
Conversation
Follow-up to #158, which added invite_delivery 'none' without the wording and `guards agreed when it was designed. Four gaps, all in the event type editor: - The mode read "No one (you send your own)", a negation that looks like a mistake. It is now "Your own system", which reads as a deliberate choice. - Choosing it while email is not configured emails the booker nothing at all, and that is easy to do by accident and impossible to notice later, so it is confirmed once. The selection is held back until confirmed, and cancelling leaves the previous mode in place. - A permanent line says the setting applies to new bookings only, because the mode is copied onto a booking when it is created and later changes do not reach existing ones. - With an online location the booking still has a join link, and Calnode will not send it. The editor now says so and names location_value in the booking.created webhook, which is where an integration finds it. One implementation note: bits-ui keeps the clicked option as its internal selection even when the bound value is not changed, so after a cancel, re-picking the same option fired no change event and the dialog never reappeared. The Select is keyed on a counter that increments when a choice is declined, which remounts it against the current value. Verified in a browser: select, cancel, reselect, dialog reopens; confirm, the value applies; an online location shows the join-link warning.
There was a problem hiding this comment.
Important
The new join-link warning states Calnode will not send the join link to the booker, but under none Calnode still emails the confirmation with LocationValue in the body whenever email is configured.
Reviewed changes
- Mode renamed — the
noneoption now reads "Your own system" instead of the negation-style "No one (you send your own)". - Confirm on silent selection — picking
nonewhileinvite_sender_ready === falseholds the value and opensConfirmDialog; a declined choice remounts theSelectvia{#key inviteSelectReset}because bits-ui keeps the clicked item as its internal selection. - Non-retroactive note — permanent line stating the setting applies to new bookings only.
- Join-link warning — amber callout for
none+ an online location, pointing atlocation_valuein thebooking.createdwebhook.
deepseek-v4.1-flash | 𝕏
| {#if form.invite_delivery === 'none' && isOnlineLocation(form.location_type)} | ||
| <p class="mt-3 rounded-md border border-amber-200 bg-amber-50 px-3 py-2 text-sm text-amber-800"> | ||
| This event type books an online meeting, so every booking has a join link, and Calnode will | ||
| not send it to the booker. Pass its <code class="font-mono">location_value</code> from the | ||
| <code class="font-mono">booking.created</code> webhook in your own confirmation. |
There was a problem hiding this comment.
This claim is only true when email is not configured. Under invite_delivery = 'none' the backend only detaches the .ics; the booker's confirmation email still goes out and renders LocationValue (the minted join link) in its body, so on the common email-configured setup the warning tells operators their integration must deliver a link Calnode already delivers.
Technical details
# Join-link warning contradicts actual `none` delivery
## Affected sites
- `frontend/src/routes/event-types/[slug]/+page.svelte:822-827` — warning renders for every `none` selection, regardless of `et.invite_sender_ready`.
- `internal/handler/invite_delivery.go:94-98` — `applyInviteDelivery` for `InviteByNone` sets only `d.AttachICS = false`; it does not suppress the email or clear `LocationValue`.
- `internal/mailer/html.go:76` / `internal/mailer/booking.go:442-443,471-472,524-525` — the booker email body includes `LocationValue`.
- `internal/handler/templates/book.html:773` — the post-booking confirmation page also shows `location_value` on screen.
## Required outcome
- The copy must be accurate in both configurations: email configured (Calnode's confirmation email still carries the join link, only the calendar invite is withheld) and email not configured (the booker receives nothing from Calnode).
- Either gate this block on `et?.invite_sender_ready === false` like the adjacent `calnode` warning, or reword it to say Calnode's email still shows the link while no calendar invite is sent.
## Open questions for the human
- Should the webhook guidance appear only when the operator is replacing Calnode's confirmation entirely, or always as a pointer?| const PLATFORM_PROVIDER: Record<string, string> = { google_meet: 'google', teams: 'microsoft' }; | ||
| const isOnlineMeeting = (t: string) => t === 'google_meet' || t === 'teams'; | ||
| // Any location that produces a join link the booker has to receive somehow. | ||
| const isOnlineLocation = (t: string) => isOnlineMeeting(t) || t === 'zoom' || t === 'livekit'; |
There was a problem hiding this comment.
isOnlineLocation omits link and the legacy custom_video, even though both produce a join link the booker needs the same way (the comment above it says "any location that produces a join link"). With none and no email, a link event type delivers the booker nothing and this warning never appears — deliberate, or an oversight?

Follow-up to #158, which added
invite_delivery = 'none'. The backend is fine; the editor never got the wording and guards agreed during review. Four changes, all in the event type editor.1. The mode is named for what it does
No one (you send your own)reads as a negation, which looks like a mistake. It is nowYour own system, which reads as a deliberate integration choice.2. It is confirmed when email is not configured
Choosing it with no email set means the booker receives nothing at all from Calnode, and the host's calendar invites nobody either. That is easy to pick by accident and impossible to notice afterwards, so the selection is held and a confirm dialog explains the consequence. Cancelling leaves the previous mode. When email is configured there is nothing silent to warn about, so no dialog appears.
3. It says the setting is not retroactive
A permanent line under the field: "Applies to new bookings only. Existing bookings keep the method they were sent with." That is true because the mode is copied onto each booking at creation.
4. It warns about the join link
With an online location every booking still has a join link, and Calnode will not send it under this mode. The editor now says so and names
location_valuein thebooking.createdwebhook as where the integration finds it. Shown for Google Meet, Teams, Zoom and LiveKit.A bug in my first attempt, found by rendering it
bits-ui keeps the clicked option as its internal selection even when the bound value is not changed. So after cancelling, picking the same option fired no change event and the dialog never reopened. The Select is now keyed on a counter that increments when a choice is declined, remounting it against the current value.
Verification
Driven in a real browser against a scratch instance, not just type-checked:
pnpm checkreports 0 errors andpnpm buildsucceeds.Note for the release
#158 added migration
00071, which rebuilds theinvite_deliverycolumn onbookingsandevent_types. The release carrying it should tell operators to back up first. Millisecond work at this data size, but not something to run without a restore point.