Repository navigation
packaging(ns8): poll for the route instead of checking it once #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,9 +116,10 @@ after restoring, the app served 200, logged "keyvault: DEK unwrapped from | |
| keystore", the encryption-key fingerprint was unchanged, and an event type | ||
| created before the backup was still there. | ||
|
|
||
| The `tests/` robot suite is wired up and dry-run clean (5/5, Robot 7.5), but it | ||
| has still never been executed against a live cluster. Every live check above | ||
| was done by hand. See [Testing](#testing). | ||
| The `tests/` robot suite has now been run against a live cluster: 4/4 without | ||
| the browser and 5/5 with `RUN_UI_TESTS=true`, on a single-node NS8 built from | ||
| `ns8-core@ns8-stable` on Rocky 9.8. Running it is what turned up the | ||
| route-registration race described in [Testing](#testing). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The pointer says the race is described in |
||
|
|
||
| ## Uninstall | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
5/5 with RUN_UI_TESTS=trueclaim is contradicted by the PR's own Verification section, which still ends with "The[ui]test is still the only one that has never executed; it needsRUN_UI_TESTS=trueand the Playwright image." One of the two is stale — worth resolving in whichever is wrong, since the line this paragraph replaces existed precisely because an unverified claim about what had actually been run was a problem.