Skip to content

Branding does not get sent with any email at all after the fixes #191

Closed as not planned

Description

@MinosChatzidakis

Before submitting

  • I've searched existing issues and this isn't a duplicate.
  • This is a reproducible bug in Calnode — not a configuration/setup question or a feature request.

What's the bug?

After the recent changes (v0.12.0), branding got reworked because it wasn't being attached to reminder emails.
However, it now seems like it doesn't get sent with any email.
I have tried locating the faulty code to no avail.

Steps to reproduce

  1. Add branding via the settings
  2. Book a meeting. The branding you added should be there in the booking page
  3. View the emails sent to the host and the attendee. The branding should be absent

Calnode version / commit

v0.12.0

How are you running Calnode?

Self-hosted — Docker

Logs, screenshots, or anything else

No response

Activity

  1. pullfrog commented on Oct 29, 2026

    @pullfrog
    Contributor
  2. shockalotti commented on Oct 29, 2026

    @shockalotti
    Contributor

    Thanks for the report. Two things changed since you filed this, and one of them matters for the diagnosis.

    v0.12.0 was released at 20:59Z on 2026-10-29, and your report was filed at 15:10Z the same day. So whatever you were running was not v0.12.0, even though the version field said so. Please retest on v0.12.0 first, and if it still happens, tell me the image digest (docker inspect --format '{{index .RepoDigests 0}}' <container>) so we know exactly which build we are discussing.

    For context, branding is confirmed working on the code you would have had:

    • On a real v0.11.2 deployment, both the booking confirmation and the reminder render the logo in the mail client.
    • On the v0.12.0 tag, an automated check asserts the attendee confirmation and the host notification both carry the absolute logo URL, banner URL and business name, in both invite-delivery modes.

    So the templates and the branding loader are not dropping it. If you can still reproduce on v0.12.0, the difference is almost certainly configuration or delivery:

    1. Is Business name set, or only a logo and banner? A blank name falls back to "Calnode" in the footer, and if your client also blocks remote images the email looks entirely unbranded even though the logo tag is present.
    2. What is in the HTML? "Show original" on one email, and paste the <img src="..."> value for the logo.
    3. Does that URL open from outside your network? If it resolves to localhost or an internal host, your PUBLIC_BASE_URL is wrong and the booking page only works because it is same-origin.
    4. SMTP or Resend?

    If the raw source has no text/html part at all, that is a different failure and I will chase it properly.

  3. MinosChatzidakis commented on Nov 1, 2026

    @MinosChatzidakis
    ContributorAuthor

    False alarm after all, I was testing a couple of things locally and was using localhost as my base url. So the mailer couldn't resolve the url for the images. Rookie mistake on my end, thanks for the time you took to reply however. (And yes I wasn't using v0.12.0, but v.0.11.2 so that was a typo in my report)

  4. shockalotti commented on Nov 1, 2026

    @shockalotti
    Contributor

    Glad it is sorted, and no harm done — that is a genuinely easy one to hit, since localhost works for the booking page and only breaks in email. Thanks for coming back with the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions