Repository navigation
Conversation
Owner
|
Oh wow, nice start! This is something I have been postponing for a long time |
# Conflicts: # public/script.js # src/index.tsx
Extract server URL into a dedicated serverUrl() helper with explicit fallbacks for hostname and port. This addresses the review finding that app.server?.hostname and app.server?.port may be undefined at creation time (Elysia's Server type is a union that doesn't expose these directly). Co-Authored-By: Claude Code <noreply@anthropic.com>
Laertes87
force-pushed
the
MigrateFromClientsideJavascript
branch
from
October 26, 2026 20:55
8d1b79e to
21dbe23
Compare
Laertes87
force-pushed
the
MigrateFromClientsideJavascript
branch
from
November 3, 2026 11:58
d2a2cbd to
09cff94
Compare
Port ?to=&converter= format pre-selection from script.js to script.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Laertes87
force-pushed
the
MigrateFromClientsideJavascript
branch
from
November 18, 2026 21:04
09cff94 to
94d0989
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Laertes87
marked this pull request as ready for review
November 18, 2026 21:28
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 30 files
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
- drop failed uploads and keep Convert disabled until all uploads succeed - reset the selected format when the last file is removed - select targets on click (keyboard support) and keep focus on mousedown - set the submit input's value for the upload state label - delete history jobs in batches of at most 100 - rebuild client bundles in watch mode for dev and hot - derive bundled client scripts from page references in build test - tighten test fixture and names in client and eden tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Laertes87
force-pushed
the
MigrateFromClientsideJavascript
branch
from
November 21, 2026 20:02
5fed7c8 to
d90a6cc
Compare
C4illin
reviewed
Nov 22, 2026
| fileInput.setAttribute("accept", `.${fileType}`); | ||
| setTitle(); | ||
|
|
||
| postConversions({ fileType: extension }) |
Owner
There was a problem hiding this comment.
Suggested change
| postConversions({ fileType: extension }) | |
| postConversions({ fileType: extension, fileName: file.name }) |
just a small change so we can handle the file extension correctly
Collaborator
Author
There was a problem hiding this comment.
the fileName is added
C4illin
reviewed
Nov 22, 2026
| const api = edenFetch<App>(webroot); | ||
|
|
||
| // ── Route helpers (typed via @elysiajs/eden inference from App) ──────────────── | ||
| async function postConversions(body: { fileType: string }): Promise<string> { |
Owner
There was a problem hiding this comment.
also change here to pass along fileName
C4illin
approved these changes
Nov 22, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm playing around a bit with agentic coding using local LLMs. I thought I'd tackle this feature that way. This PR still needs a lot of thorough testing.
Summary
Migrates the inline/client-side JavaScript to typed TypeScript client scripts that talk to the server via Elysia Eden.
Client scripts
public/script.jsandpublic/results.jswithpublic/script.ts,public/results.ts, and a newpublic/history.ts.src/pages/history.tsx(~100 lines), moving it intohistory.ts.src/eden.ts(typed Eden client, centralized server URL).findPresetTarget,historySelection, andnormalizeFiletypetweaks. The ffmpeg converter andconverters/main.tshave small related changes. These also support the wav-3cx preset and URL-param format pre-selection.Build & tooling
package.json,bun.lock,bunfig.toml,tsconfig*.json, andeslint.config.ts.history.js) are git-ignored.Review fixes
Array.fromso the tsc build passes.Tests
tests/client/*), plus Eden app, helper, and build-script tests.<script>tags (matched case-insensitively).