Repository navigation
Maintenance cleanup: JSON migration, inspection fixes, and dedupe helpers - #123
Merged
Merged
Conversation
Drop the duplicate JSON library so network APIs and stats use typed org.json objects end-to-end.
Move KML command-block data to PersistentDataContainer, drop UnsafeValues protocol checks, and switch menus/items off deprecated display APIs.
Generator startup notifies console without a player; fall back to the default locale instead of NPEing in Messages.locale.
Let KotlinModuleMetadataTransformer see okhttp/okio/stdlib metadata instead of dropping duplicates under the default EXCLUDE strategy.
…nd KML Collapse duplicated accumulation, material-item, palette chat/text, selection chrome, and KML placement/material paths into shared helpers.
…direction helper Use records for immutable holders and pull the yaw-to-schematic direction choice out of FieldScripts.
Normalize zip entry paths and reject extractions that escape the destination directory.
Fix typos, prefer positive boolean helpers, tighten finals, drop dead stubs, and modernize MenuItems switches from the inspection pass.
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
…essage Look up CCA2 from the full region registry instead of only the team's owned regions, and stop messaging the player from that helper so ownership failures are reported once.
Avoid NPEs on null region country codes, treat blank Photon codes as missing so CCA2 enrichment runs, open warp edit menus on the main thread, rebuild the HTTP User-Agent per request, and parse Nominatim display names safely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json-simpleusage toorg.json, clear Paper/Canvas deprecations (including KML PDC), and make message rendering null-player safe for console/generator startup.Region/QueuedRequestto records..kotlin_moduleduplicate handling, and apply the remaining worthwhile inspection cleanups (typos, finals, inverted booleans, MenuItems switches).Test plan
./gradlew compileJava test/btt/ stats menu after JSON migration pathsMade with Cursor