Repository navigation
chore: bump bitgo sdk and pin transitive CVE fixes - #298
Conversation
37217ac to
d2a58ec
Compare
d2a58ec to
9fdd149
Compare
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
ReviewNo Critical or blocking findings. The change is a dependency bump plus a small guard in the ECDSA recovery handler. I reviewed everything except Key safety: nothing in the diff logs, serializes, or transmits key material. The Notes (non-blocking):
Tests: the new 🤖 Generated with Claude Code |
Bump the
@bitgo-beta/*SDK packages, pin transitive CVE fixes, and adapt MBE recovery to the new SDK.@bitgo-beta/*dependencies and thesdk-core/staticsoverrides to the latest betas, and regeneratepackage-lock.json.follow-redirects,node-forge,joiandbody-parserto their fixed versions so the Trivy HIGH gate passes.body-parseroverride because express 4.21.2 pins it at 1.20.3, which a lockfile regen cannot fix.recoverEcdsaMPCv2Wallets, throw if eth-likeuserKeyis missing, beforerecover()runs, since the new SDK made it optional.Tests
testUtils.ts: addnockEthWalletIsSignerto mock the EtherscanisSigner(address)calls the new SDK makes for both recovery keys.recoveryWallet.test.tsandmusigRecovery.test.ts: use the helper in the EVM recovery tests and assert the signer calls are consumed.recoveryEcdsa.test.ts: eth-like recovery withoutuserKeyis rejected beforerecover()or the AWM client is called.Ticket: WCN-4223