Skip to content

fix(root): pin express Docker build to release SHA (WCI-2204) - #10152

Open
rishikeshdadam136 wants to merge 1 commit into
masterfrom
WCI-2204
Open

rishikeshdadam136 wants to merge 1 commit into
masterfrom
WCI-2204

Conversation

@rishikeshdadam136

@rishikeshdadam136 rishikeshdadam136 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

TICKET: WCI-2204

Description

Bind the bitgo/express Docker release build to the commit the release job published from, instead of re-resolving mutable git refs at publish time.

  • release-bitgojs records and exports the publish commit SHA (publish-sha).
  • get-express-release-context checks out that SHA and verifies the @bitgo/express@<version> tag resolves to a commit carrying the released express version within the published release history; the image is built from the verified tag commit, and the build fails closed otherwise.
  • The release summary now shows the verified publish SHA.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • actionlint passes on the modified workflow.
  • The verification logic was exercised against a synthetic release history: legitimate releases pass; out-of-position or missing tags fail closed (6/6 scenarios).

See the Linear ticket (WCI-2204) for full details.

@linear-code

linear-code Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

WCI-2204

@rishikeshdadam136

Copy link
Copy Markdown
Contributor Author

@claude review this pr

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the inline finding, I looked at two other things and neither is a problem. First, an empty publish-sha: get-express-release-context lists release-bitgojs in needs and only runs when dry-run is false and that job succeeded, so the output is always set. Second, the new ${{ }} interpolations in the verify step: they only carry a git rev-parse SHA and the express version read from the checked-out package.json, not external event input.

Extended reasoning...

The change touches only .github/workflows/npmjs-release.yml, which is the release pipeline that publishes the bitgo/express Docker image. The CODEOWNERS wildcard covers that file. The inline finding already marks this PR for human review, so this body only records the two other concerns I checked and ruled out.

Comment thread .github/workflows/npmjs-release.yml Resolved
@rishikeshdadam136

Copy link
Copy Markdown
Contributor Author

@claude

@rishikeshdadam136

Copy link
Copy Markdown
Contributor Author

@claude review please

Comment thread .github/workflows/npmjs-release.yml Resolved
@rishikeshdadam136

Copy link
Copy Markdown
Contributor Author

@claude review again

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@rishikeshdadam136
rishikeshdadam136 marked this pull request as ready for review November 10, 2026 10:47
@rishikeshdadam136
rishikeshdadam136 requested review from a team as code owners November 10, 2026 10:47

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant