Repository navigation
fix(root): pin express Docker build to release SHA (WCI-2204) - #10152
rishikeshdadam136 wants to merge 1 commit into
Conversation
8403ab0 to
0f0c642
Compare
|
@claude review this pr |
There was a problem hiding this comment.
Besides the inline finding, I looked at two other things and neither is a problem. First, an empty publish-sha: get-express-release-context lists release-bitgojs in needs and only runs when dry-run is false and that job succeeded, so the output is always set. Second, the new ${{ }} interpolations in the verify step: they only carry a git rev-parse SHA and the express version read from the checked-out package.json, not external event input.
Extended reasoning...
The change touches only .github/workflows/npmjs-release.yml, which is the release pipeline that publishes the bitgo/express Docker image. The CODEOWNERS wildcard covers that file. The inline finding already marks this PR for human review, so this body only records the two other concerns I checked and ruled out.
|
@claude review please |
9b995bf to
075bb73
Compare
075bb73 to
2cea0c6
Compare
|
@claude review again |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
TICKET: WCI-2204
Description
Bind the
bitgo/expressDocker release build to the commit the release job published from, instead of re-resolving mutable git refs at publish time.release-bitgojsrecords and exports the publish commit SHA (publish-sha).get-express-release-contextchecks out that SHA and verifies the@bitgo/express@<version>tag resolves to a commit carrying the released express version within the published release history; the image is built from the verified tag commit, and the build fails closed otherwise.Type of change
How Has This Been Tested?
actionlintpasses on the modified workflow.See the Linear ticket (WCI-2204) for full details.