Repository navigation
refactor(sdk-api): make SJCL the single v1 decrypt engine - #10144
Merged
pranavjain97 merged 1 commit intoNov 10, 2026
Merged
pranavjain97 merged 1 commit into
pranavjain97 merged 1 commit into
Conversation
Contributor
Every runtime now screens the v1 envelope with the shared assertSafeLegacyV1Envelope guard from sdk-core (iter cap, ccm-only) and runs sjcl.decrypt; the native node:crypto decoder and the Node SJCL fallback are gone. decryptV1WithFallback is renamed decryptV1WithSjcl, and decryptV1, parseV1Envelope and V1_MAX_ITER stay as deprecated exports. Ticket: WCN-3873
Contributor
|
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
pranavjain97
force-pushed
the
pranavjain/wcn-3873-sdk-use-sjcl-as-the-single-v1-decrypt
branch
from
November 9, 2026 19:56
053ff53 to
597a5a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes SJCL the only v1 decrypt engine on every runtime:
assertSafeLegacyV1Envelopescreens the envelope (iter cap 100k, ccm-only, read with SJCL's own decoder), thensjcl.decrypt. Removes the nativenode:cryptodecoder, the Node SJCL fallback, and the browser branch. The two parsers could disagree on what a valid envelope is (whitespace-key bypass, WCN-3831), and clients have hit the fallback warning in the field, so the native path buys nothing.Ticket: WCN-3873