Repository navigation
feat(sdk-core): forward WalletConnect message origin - #10133
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Forward the optional origin marker from message and typed-data signing to the corresponding request intents. WalletConnect message requests need the marker so wallet-platform can classify their origin and surface security-check details. Ticket: DEFI-1069 Session-Id: 8d487d8e-6f3c-4f43-800e-e821a42bc095 Task-Id: 7521e2e4-2ed0-4ff5-ab9c-25d0b172ce0f
|
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
nvjsr
left a comment
There was a problem hiding this comment.
Reviewed end to end.
- Marker forwarding: all four message/typed-data intent builders (buildSignMessageRequest → /msgrequests, createTxRequestWithIntentForTypedDataSigning → /txrequests, the deprecated message-signing builder) forward isWalletConnectTx; conditional spread omits the key when unset, so the wire body stays absent-or-true — matches the WP codec contract (t.literal(true)).
- Typing: isWalletConnectTx?: true (literal) on IntentOptionsForMessage / IntentOptionsForTypedData / both Populated intents / WalletSignMessageBase — prevents false at compile time, consistent with DEFI-1013's send marker.
- Resume path: when signing resumes by txRequestId the marker is not re-sent and the existing request keeps its original classification — asserted by the resume tests.
- No txChannel key is ever constructed client-side (hasOwnProperty assertions), and tests cover the full marker/absent × msgrequests/txrequests/typed-data matrix plus wallet-level teth/tsol flows.
Verified against the WP side (bitgo-microservices#64175): /msgrequests MessageIntent and the /txrequests CreateTransactionRequestIntentCodec both declare t.literal(true), so every shape this SDK emits is accepted server-side.
Ticket: DEFI-1069
Description
Forward the optional
isWalletConnectTxmarker through message and typed-data signing intents, including both message request routes. It is metadata, not an authorization signal.WalletConnect message requests need this marker so wallet-platform can classify their origin and display security-check details. Deployment also requires wallet-platform support and a newly published SDK consumed by the clients.
Issue Number
DEFI-1069
Type of change
How Has This Been Tested?
Checklist:
Ticket: DEFI-1069