Repository navigation
feat(sdk-core): upgrade v1 user keys to argon2 on sign - #10129
Open
pranavjain97 wants to merge 7 commits into
Open
pranavjain97 wants to merge 7 commits into
pranavjain97 wants to merge 7 commits into
Conversation
Contributor
pranavjain97
force-pushed
the
pranavjain/wcn-285-sdk-silent-v1-to-v2-re-encryption-of-user-key-on-transaction
branch
from
November 4, 2026 21:05
587e6a1 to
c20c23b
Compare
Contributor
|
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in upgrading of v1 user keys to v2 (argon2) encryption when a user signs. The upgrade runs in the background, after signing, and never blocks or fails the signing call.
Enabling it
BitGoconstructor optionupgradeEncryptionOnSign(defaultfalse), read throughbitgo.isUpgradeEncryptionOnSignEnabled().upgradeEncryption?: booleanon signing options, which overrides the constructor setting. It is never sent to the server.Where it runs
wallet.signTransaction(multisig, TSS, OFC),wallet.signMessage,wallet.signTypedDatapendingApproval.approve(TSS recreate and sign)payInvoiceandwithdrawOnchain(user auth key)Safety
encryptedPrv, so the server rejects it if the key changed in the meantime. That case is reported asskipped: keyChanged.Issue Number
WCN-285